From owner-svn-src-head@freebsd.org  Wed Sep  9 18:08:36 2020
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id A91A23D7933
 for <svn-src-head@mailman.nyi.freebsd.org>;
 Wed,  9 Sep 2020 18:08:36 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4Bmql844JQz4Z02
 for <svn-src-head@freebsd.org>; Wed,  9 Sep 2020 18:08:36 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com
 [209.85.160.180])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 (Authenticated sender: kevans)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 6A93311334
 for <svn-src-head@freebsd.org>; Wed,  9 Sep 2020 18:08:36 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mail-qt1-f180.google.com with SMTP id k25so2699085qtu.4
 for <svn-src-head@freebsd.org>; Wed, 09 Sep 2020 11:08:36 -0700 (PDT)
X-Gm-Message-State: AOAM533d/ckShr6qcrpGKm87vq+z0OFrmnilTbNvDquKK5PmPxT7n92o
 zJs16RH9ZQADjLpmQVbjY7zpIv1EWcd7R97GGA0=
X-Received: by 2002:ac8:72d6:: with SMTP id o22mt4521148qtp.53.1599674915847; 
 Wed, 09 Sep 2020 11:08:35 -0700 (PDT)
MIME-Version: 1.0
References: <202009091807.089I7DIv055428@repo.freebsd.org>
In-Reply-To: <202009091807.089I7DIv055428@repo.freebsd.org>
From: Kyle Evans <kevans@freebsd.org>
Date: Wed, 9 Sep 2020 13:08:23 -0500
X-Gmail-Original-Message-ID: <CACNAnaF8_9ePZ6aaysU64=S2uo-7-TRBmc8zDBF+Ae5fpy+Pnw@mail.gmail.com>
Message-ID: <CACNAnaF8_9ePZ6aaysU64=S2uo-7-TRBmc8zDBF+Ae5fpy+Pnw@mail.gmail.com>
Subject: Re: svn commit: r365506 - in head: include lib/libc/gen lib/libc/sys
Cc: src-committers <src-committers@freebsd.org>,
 svn-src-all <svn-src-all@freebsd.org>, 
 svn-src-head <svn-src-head@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Sep 2020 18:08:36 -0000

On Wed, Sep 9, 2020 at 1:07 PM Kyle Evans <kevans@freebsd.org> wrote:
>
> Author: kevans
> Date: Wed Sep  9 18:07:13 2020
> New Revision: 365506
> URL: https://svnweb.freebsd.org/changeset/base/365506
>
> Log:
>   getlogin_r: fix the type of len
>
>   getlogin_r is specified by POSIX to to take a size_t len, not int. Fix our
>   version to do the same, bump the symbol version due to ABI change and
>   provide compat.
>
>   This was reported to break compilation of Ruby 2.8.
>
>   Some discussion about the necessity of the ABI compat did take place in the
>   review. While many 64-bit platforms would likely be passing it in a 64-bit
>   register and zero-extended and thus, not notice ABI breakage, some do
>   sign-extend (e.g. mips).
>
>   PR:           247102
>   Submitted by: Bertram Scharpf <software@bertram-scharpf.de> (original)
>   Submitted by: cem (ABI compat)
>   MFC after:    1 week
>   Differential Revision:        https://reviews.freebsd.org/D26335
>

Argh, I dropped this =(:

Reviewed by: emaste, jhb, kib