Date: Tue, 10 Feb 2015 00:25:07 +0000 From: Glen Barber <gjb@FreeBSD.org> To: Nikolai Lifanov <lifanov@mail.lifanov.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, owner-svn-src-head@freebsd.org Subject: Re: svn commit: r278450 - head/release Message-ID: <20150210002507.GH84467@hub.FreeBSD.org> In-Reply-To: <150387d27ebf311cb4751fe39c2a080c@mail.lifanov.com> References: <201502091046.t19AkdCM067270@svn.freebsd.org> <150387d27ebf311cb4751fe39c2a080c@mail.lifanov.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--KR/qxknboQ7+Tpez Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 09, 2015 at 05:47:10PM -0500, Nikolai Lifanov wrote: > On 2015-02-09 05:46, Glen Barber wrote: > >Author: gjb > >Date: Mon Feb 9 10:46:39 2015 > >New Revision: 278450 > >URL: https://svnweb.freebsd.org/changeset/base/278450 > > > >Log: > > Revert r278445. > > > > I was going to use __FreeBSD_version to determine if > > xz(1) should be multi-threaded by default, but doing > > this will cause problems if/when the changes are merged > > from head. > > > > Sponsored by: The FreeBSD Foundation > > > >Modified: > > head/release/Makefile > > > >Modified: head/release/Makefile > > >=20 > Can you just X-MFC this with xz 5.2.0 import? > You can then refer to xz in OBJDIR to get this to work on older releases. >=20 That is the intent, but not this commit. The problem is the Makefile would contain things like: .if (${FREEBSD_VERSION} >=3D 1100059) || ((${FREEBSD_VERSION < 1100000 \ && ${FREEBSD_VERSION} >=3D 1000555)) [...]. and other varying levels of ridiculousness. It's bad enough we have to do this in the ports tree. I certainly do not intend to implement this behavior in the src tree. With regards to the OBJDIR, actual releases (not always snapshots) are always built from the same major FreeBSD version or higher. Meaning, code/features that exist in releng/10.1 are available already in stable/10 at the time. In this particular case, I care less about snapshot builds and more about the release builds, which in this particular case, we are far off in the future enough that it is guaranteed the feature needed will be available. Glen --KR/qxknboQ7+Tpez Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJU2U/eAAoJEAMUWKVHj+KThPIP/1n3TghI+4U6SK9/MGACF1vM KgPmkCAlq/PC5tqEsBhgidoLKFUj5IpbbMRj48/p80gXvxqo8Yn1UjRhvt7QymUl OELHVdtt3b8VWMM8bHBwFA5YKayImiezAqAsJhKyYfV2VYSTaaybZd6m64T4KeVR T4ZHHe/2Dr87FEfnXbOwt4gRqtd/75UUJeXoinVD/Dm8gheeHDW/9pE97uQ7nWKK jAd/cJYp7ZJ/XSZC7ZhQIbOZkxqq68UbNrVBaNFc6Yb60UjfqTGzhuCWOp2rgOnF fML7GOgxM+rwnkWHlAgX8GjfV2rw9q4Rj7yOm3O2jp4cH7s2RPJLhM+lHch56gfq waHy1CBRP4LsfeNAEQKlTr+uc5kO1yfKsBbm0Yj0xQ729U6FXB11HVfEEHxugNfy +ZoS0/+tZJyntL7bZkz5oYqrLMHlC4UpIANLBSW6f4OU6YOcBRXsfCwZfXAVadou Y0KkC3TyL3FNM6UhfJfVKssFG7QQcQp7thoDI2P9cDm2rC13laYkKtPWZiH7DObv UDq+rdmuksukBwWeikznq8AZBpD5RzA09xhc1ei5VRfLLlRpoFoBGIL4V/e2fbmS 0tj+3jjnCUq/I7YxYZXhnQMd1tMWqnGkvSghoo12zBwGNXMJlM2ulfLBgT8pbQJd +JnH+QX25Y//CEdIcNhB =R4ia -----END PGP SIGNATURE----- --KR/qxknboQ7+Tpez--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150210002507.GH84467>