From owner-freebsd-hackers@FreeBSD.ORG  Sat Feb 28 21:19:55 2015
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id DB33F12D
 for <freebsd-hackers@freebsd.org>; Sat, 28 Feb 2015 21:19:55 +0000 (UTC)
Received: from mail-ig0-x229.google.com (mail-ig0-x229.google.com
 [IPv6:2607:f8b0:4001:c05::229])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id AAF5EA05
 for <freebsd-hackers@freebsd.org>; Sat, 28 Feb 2015 21:19:55 +0000 (UTC)
Received: by igdh15 with SMTP id h15so8672434igd.4
 for <freebsd-hackers@freebsd.org>; Sat, 28 Feb 2015 13:19:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=6s+dAYt4P3KfGjcIXHMmoScMi8TSVu6FDmeVB2NZ7sE=;
 b=c9YjeBlwMR/ieWTlsOlmM0MJ6PCAJ78bqsawHmd3O58BnhPYBycVLMjJCsAt9uRT0E
 rSDy0/iC7UwZdxVc5z+95NWG3xS1kg7SJe8GPH07/DNfvHUZaWJmBzStUDl2bq2NILGS
 4l04SYGA3NhDf9RytrdG39WvzZ8w3M/s/QlMYYIDUX9uq6t5ty712wcsZZWwIY7C8TEu
 Q1pxou5JujYU1ggfbgeTsFRIT31Zb5h+gWif4Ucc7HC788Rwv9ugQNsQ+ZFOY344OhFn
 Okc74TF663kSso9m7aT6TQdGi141X480jHHBBeSeQTdZ7xgPMUEi7EaA/qJR1Y5F1tZc
 yruA==
MIME-Version: 1.0
X-Received: by 10.107.168.5 with SMTP id r5mr26697905ioe.87.1425158394960;
 Sat, 28 Feb 2015 13:19:54 -0800 (PST)
Received: by 10.107.156.75 with HTTP; Sat, 28 Feb 2015 13:19:54 -0800 (PST)
In-Reply-To: <54F1D602.6050108@M00nBSD.net>
References: <54F1D602.6050108@M00nBSD.net>
Date: Sat, 28 Feb 2015 16:19:54 -0500
Message-ID: <CAFMmRNwFzCL7GQnfFUCSzmZf_nRN0_DjApp=ZJHrrVgYK696XA@mail.gmail.com>
Subject: Re: Brainy: Set of 17 potential bugs
From: Ryan Stone <rysto32@gmail.com>
To: Maxime Villard <max@m00nbsd.net>
Content-Type: text/plain; charset=UTF-8
Cc: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org>
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Feb 2015 21:19:55 -0000

Interesting tool.  I've looked at the two reports in sys/kern and they
seem to be legitimate.

The memory leak in uipc_accf.c is explicitly noted in a comment before
accept_filt_add().  That probably indicates that it's a tough bug to
fix.  Ugh.

The second, in uipc_syscalls.c, looks pretty simple.  I've raised a
code review for the fix:

https://reviews.freebsd.org/D1989


Thanks for the report.  I'll try to work my way through all of the issues.