From owner-freebsd-current@FreeBSD.ORG Mon Sep 20 21:53:21 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC95816A4CE for ; Mon, 20 Sep 2004 21:53:21 +0000 (GMT) Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5EEF143D1D for ; Mon, 20 Sep 2004 21:53:21 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 23906 invoked from network); 20 Sep 2004 21:53:21 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 20 Sep 2004 21:53:20 -0000 Received: from [10.50.40.210] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i8KLrEqZ026257; Mon, 20 Sep 2004 17:53:16 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Roman Kurakin Date: Mon, 20 Sep 2004 17:47:43 -0400 User-Agent: KMail/1.6.2 References: <41421D6A.8070805@cronyx.ru> <200409201652.24457.jhb@FreeBSD.org> <414F4AAC.5000807@cronyx.ru> In-Reply-To: <414F4AAC.5000807@cronyx.ru> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200409201747.43612.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Roman Kurakin cc: FreeBSD Current cc: Nate Lawson Subject: Re: mp_machdep.c (was Re: [Fwd: Re: Bug reports requested - acpi]) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2004 21:53:22 -0000 On Monday 20 September 2004 05:25 pm, Roman Kurakin wrote: > John Baldwin: > >On Monday 20 September 2004 02:46 pm, Roman Kurakin wrote: > >>Hi, > >> > >> I have problem with one of my SMP systems (see end of letter). > >>It looks that following patch: > >> > >>Index: mp_machdep.c > >>=================================================================== > >>RCS file: /home/ncvs/src/sys/i386/i386/mp_machdep.c,v > >>retrieving revision 1.238 > >>diff -u -r1.238 mp_machdep.c > >>--- mp_machdep.c 1 Sep 2004 06:42:01 -0000 1.238 > >>+++ mp_machdep.c 20 Sep 2004 18:20:49 -0000 > >>@@ -747,6 +747,11 @@ > >> POSTCODE(INSTALL_AP_TRAMP_POST); > >> > >> pmap_kenter(boot_address + KERNBASE, boot_address); > >>+#ifdef I386_CPU > >>+ invltlb(); > >>+#else > >>+ invlpg((u_int)dst); > >>+#endif > >> for (x = 0; x < size; ++x) > >> *dst++ = *src++; > >> > >>solves the problem. I'll check it on not very recent hacked current. > >>So this is initial request. I'll check it with current current without my > >>hacks to double check that this works always and inform if this helps. > >> > >> The intent of this letter to ask community if this workaround for my > >>problem or real bug fix. If this is only workaround please let me know > >>and I'll continue to dig with version I currently use. > >>(I don't like workarounds) > >> > >>Best regards, > >> Roman Kurakin > > > >It's probably cleaner to use pmap_invalidate_range(). Something like: > > Hm, what about pmap_invalidate_page () or even pmap_map () ? > > Index: mp_machdep.c > =================================================================== > RCS file: /usr/cvs/src/sys/i386/i386/mp_machdep.c,v > retrieving revision 1.238 > diff -u -r1.238 mp_machdep.c > --- mp_machdep.c 1 Sep 2004 06:42:01 -0000 1.238 > +++ mp_machdep.c 20 Sep 2004 20:50:35 -0000 > @@ -738,15 +738,15 @@ > int x; > int size = *(int *) ((u_long) & bootMP_size); > u_char *src = (u_char *) ((u_long) bootMP); > u_char *dst = (u_char *) boot_address + KERNBASE; > u_int boot_base = (u_int) bootMP; > u_int8_t *dst8; > u_int16_t *dst16; > u_int32_t *dst32; > > POSTCODE(INSTALL_AP_TRAMP_POST); > > - pmap_kenter(boot_address + KERNBASE, boot_address); > + pmap_map((vm_offset_t)dst, boot_address, boot_address + size, 0); > for (x = 0; x < size; ++x) > *dst++ = *src++; This changes the value of 'dst', which is bad. :) I looked at using it but decided not to because of that. > >It seems odd that this is needed though. Does it go away if you use > >DISABLE_PSE or DISABLE_PGE? > > I'll check this. > > rik -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org