From owner-svn-src-projects@freebsd.org Wed Aug 17 07:30:24 2016
Return-Path: <owner-svn-src-projects@freebsd.org>
Delivered-To: svn-src-projects@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
[IPv6:2001:1900:2254:206a::19:1])
by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE865BBB8AE
for <svn-src-projects@mailman.ysv.freebsd.org>;
Wed, 17 Aug 2016 07:30:24 +0000 (UTC)
(envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
[IPv6:2610:1c1:1:6068::e6a:0])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client did not present a certificate)
by mx1.freebsd.org (Postfix) with ESMTPS id 849801868;
Wed, 17 Aug 2016 07:30:24 +0000 (UTC)
(envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u7H7UNXr008014;
Wed, 17 Aug 2016 07:30:23 GMT (envelope-from ngie@FreeBSD.org)
Received: (from ngie@localhost)
by repo.freebsd.org (8.15.2/8.15.2/Submit) id u7H7UNwT008013;
Wed, 17 Aug 2016 07:30:23 GMT (envelope-from ngie@FreeBSD.org)
Message-Id: <201608170730.u7H7UNwT008013@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: ngie set sender to
ngie@FreeBSD.org using -f
From: Garrett Cooper <ngie@FreeBSD.org>
Date: Wed, 17 Aug 2016 07:30:23 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject: svn commit: r304269 -
projects/fix-libarchive-tests-after-r304075/contrib/libarchive/libarchive/test
X-SVN-Group: projects
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "SVN commit messages for the src " projects"
tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-projects>,
<mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-projects>,
<mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Aug 2016 07:30:24 -0000
Author: ngie
Date: Wed Aug 17 07:30:23 2016
New Revision: 304269
URL: https://svnweb.freebsd.org/changeset/base/304269
Log:
Ensure that f has been properly fopen'ed before trying to fwrite to it
CID: 1331454
Reported by: Coverity
Sponsored by: EMC / Isilon Storage Division
Modified:
projects/fix-libarchive-tests-after-r304075/contrib/libarchive/libarchive/test/test_fuzz.c
Modified: projects/fix-libarchive-tests-after-r304075/contrib/libarchive/libarchive/test/test_fuzz.c
==============================================================================
--- projects/fix-libarchive-tests-after-r304075/contrib/libarchive/libarchive/test/test_fuzz.c Wed Aug 17 07:25:50 2016 (r304268)
+++ projects/fix-libarchive-tests-after-r304075/contrib/libarchive/libarchive/test/test_fuzz.c Wed Aug 17 07:30:23 2016 (r304269)
@@ -141,7 +141,7 @@ test_fuzz(const struct files *filesets)
srand((unsigned)time(NULL));
for (i = 0; i < 1000; ++i) {
- FILE *f;
+ FILE *f = NULL;
int j, numbytes, trycnt;
/* Fuzz < 1% of the bytes in the archive. */
@@ -169,6 +169,7 @@ test_fuzz(const struct files *filesets)
Sleep(100);
#endif
}
+ assert(f != NULL);
assertEqualInt((size_t)size, fwrite(image, 1, (size_t)size, f));
fclose(f);