From nobody Sat Apr 22 19:06:40 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q3gqX6Zwyz468wp; Sat, 22 Apr 2023 19:06:48 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q3gqX4JMFz3l7q; Sat, 22 Apr 2023 19:06:48 +0000 (UTC) (envelope-from bz@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682190408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JN8unrxr2+DUu4EiNLDMH5Efu7cdEDpBXk2hvypuiqM=; b=TLBorauKMgZpVFWPMEbr/uttUWmocYQU9JjoLtnSO7D4I9OXTIlGgWSsye2opRKZ/WFH7W uVmSZQI6L4Xb8gwTZLukkxIMZbSQchEKU2wWsDRet8yjI2q0b+dj9RD5/MY4ufU+Dl0RrF 7hWjgsy+MBzt9QgjTGrvAFpvuG9Sg5fZyXeGSLuL6IAS8VFUYrWuYe34ecXPGKlg3x7s+i ZJenIjpGbmmvXC6HbrxLYmy4hj/bIZfowbCCEWBITxRDny9esYRT8Yt7Aa7MoqpAKdds8q r9ldQrtE84PEwrxH4wr9pN9+bqlIlDG228LHykWRJyu8paxWBXWuV/P+18d4aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682190408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JN8unrxr2+DUu4EiNLDMH5Efu7cdEDpBXk2hvypuiqM=; b=mHD3fafukQE268SSjDlmQIrzAzJL+7KQ4BU2H+uILEIIBv4xpLGpqYxz9Rq4mRWl6OJHOK rJavvvODFt8sBhSyw1Q+tGET9TLm6zF9K37dFpabl6IbUSY3+kWRf1mRxNaDYIyv8SGZ4C EiPRijbh8ErdgIFkxcJI+gYUOhq4zyM6l0E0hzMdlnwYmRsvblhol+NKQFFYRBBrkeJrGY zAg9SEQBOyPqUYUM1ECUjFoMiodJu/S4mhhXiXMqQ8sHT38uWdeUIwmE+XqtSTya3Cc6iH uug8TLSTMP0KjrEyU6F1Hrn7bY4bcknCVJCMiHxmunzYjmJzzPP9iz2KUfhRNw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682190408; a=rsa-sha256; cv=none; b=R557fAdMLYSn0fOi0Fp9xoFjCsZ+B5szZ/m7Uaw6jt2LKbC+DlIuGNpEPfx4eR6Ga0RHQa y2BilxGUYqH1NmP3Gp+ClP6y/X+woTQ4AxHOWdKsSPpnLJyGdwbIKOZ28/92G3/irUj9wY P16+iXaloGlQXw1ONL3lCar7Pu4Bhv/zSxwRFVkuk3hH1iB2Hl6vNNYFpCx4AOQpiLNEoq 1VkMxkQiVszEQEXffoYUUzk8bfLCT3aPNJAKML66E/UjZGnb7JiPLHvanHbav93C5ShsjB gdR9y7ojXJHLNwWsXVlC6SozpEcM8KGt2fdMyLkc0gXRRRyNNXC3Vm4nwj2KPg== Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:13b:39f::9f:25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE Root Certificate Authority" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Q3gqX16vmzndJ; Sat, 22 Apr 2023 19:06:48 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 110198D4A213; Sat, 22 Apr 2023 19:06:45 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 1EE0F5C3A831; Sat, 22 Apr 2023 19:06:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id 8Kx4M9lPzsqp; Sat, 22 Apr 2023 19:06:43 +0000 (UTC) Received: from netf001.sbone.de (netf001.sbone.de [IPv6:fde9:577b:c1a9:f001::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 4B64A5C3A82F; Sat, 22 Apr 2023 19:06:42 +0000 (UTC) Date: Sat, 22 Apr 2023 19:06:40 +0000 (UTC) From: "Bjoern A. Zeeb" To: Emmanuel Vadot cc: Rene Ladan , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 3082cab3f868 - main - net/wifi-firmware-*: add framework and firmware for various WiFi chipsets In-Reply-To: <20230422200746.f5de9ba748783b3c49ad6ffb@bidouilliste.com> Message-ID: <558rpr26-q19s-n3o3-7q47-011549so044s@serrofq.bet> References: <202304221526.33MFQ8Ah006135@gitrepo.freebsd.org> <20230422200746.f5de9ba748783b3c49ad6ffb@bidouilliste.com> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="1098556516-1156997341-1682190402=:2837" X-ThisMailContainsUnwantedMimeParts: N This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1098556516-1156997341-1682190402=:2837 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Sat, 22 Apr 2023, Emmanuel Vadot wrote: > On Sat, 22 Apr 2023 15:55:45 +0000 > Rene Ladan wrote: > >> On Sat, Apr 22, 2023 at 03:26:08PM +0000, Bjoern A. Zeeb wrote: >>> The branch main has been updated by bz: >>> >>> URL: https://cgit.FreeBSD.org/ports/commit/?id=3082cab3f868c1f7538d5221080703d891a2d0a6 >>> >>> commit 3082cab3f868c1f7538d5221080703d891a2d0a6 >>> Author: Bjoern A. Zeeb >>> AuthorDate: 2023-04-09 01:29:48 +0000 >>> Commit: Bjoern A. Zeeb >>> CommitDate: 2023-04-22 15:21:22 +0000 >>> >>> net/wifi-firmware-*: add framework and firmware for various WiFi chipsets >>> >>> Add a "base port framework" to fetch (WiFi) firmware and license files >>> from the linux-firmware.git repository and an accompanying FreeBSD >>> build kmod framework tarball (for now; we might do without that in >>> the future). >>> Add child ports for Realtek rtw88 and rtw89, Mediatek mt76, and >>> Atheros ath10k and ath11k firmware as a start. >>> >>> This is a beginning in order to stop bloating src.git and the >>> installed kernels with lots of MB of firmware files whereas usually >>> only one vebdor/chipset/flavor is needed. Before fully switching >>> more infrastructure needs to be in place but this is the first and >>> most important step. >>> >>> PR: 270742 >>> Reviewed by: lwhsu >>> Approved by: lwhsu (ports) >>> Differential Revision: https://reviews.freebsd.org/D39487 >>> --- >>> net/wifi-firmware-ath10k-kmod/Makefile | 88 ++++++++++++++++++++++++++ >>> net/wifi-firmware-ath10k-kmod/distinfo | 79 ++++++++++++++++++++++++ >>> net/wifi-firmware-ath10k-kmod/pkg-descr | 3 + >>> net/wifi-firmware-ath11k-kmod/Makefile | 105 ++++++++++++++++++++++++++++++++ >>> net/wifi-firmware-ath11k-kmod/distinfo | 23 +++++++ >>> net/wifi-firmware-ath11k-kmod/pkg-descr | 3 + >>> net/wifi-firmware-base/Makefile | 80 ++++++++++++++++++++++++ >>> net/wifi-firmware-mt76-kmod/Makefile | 31 ++++++++++ >>> net/wifi-firmware-mt76-kmod/distinfo | 27 ++++++++ >>> net/wifi-firmware-mt76-kmod/pkg-descr | 5 ++ >>> net/wifi-firmware-rtw88-kmod/Makefile | 34 +++++++++++ >>> net/wifi-firmware-rtw88-kmod/distinfo | 19 ++++++ >>> net/wifi-firmware-rtw88-kmod/pkg-descr | 7 +++ >>> net/wifi-firmware-rtw89-kmod/Makefile | 28 +++++++++ >>> net/wifi-firmware-rtw89-kmod/distinfo | 13 ++++ >>> net/wifi-firmware-rtw89-kmod/pkg-descr | 6 ++ >>> 16 files changed, 551 insertions(+) >>> >> Shouldn't these ports be added to net/Makefile ? >> >> Regards, >> René > > Yes it should, and I really wished this was using flavors like we do > for the gpu firmwares. Bjoern if you have questions on how to flavorise > those ports don't hesitate to ask. You may notice that there are two places in the base port already refering to FLAVOR and that the individual ports are split up into "FWSUBS" which basically is a flavour later on. These had been started very differently initially with changes to Mk/ and then were rewritten based on feedback. I'll be very happy to take this offline with you to sort flavours out for each of them. For now the reason to have them in first place was the request to not further bloat src and that should have happened months ago but on initial request no one had offered help. Next I'll need to figure out release problems for that. For immediate help (before connecting them to the build): I also got a report from dvl/freshports that the base port (which should never be built) doesn't have a pkg-descr. Do I need to add that too? /bz -- Bjoern A. Zeeb r15:7 --1098556516-1156997341-1682190402=:2837--