From owner-p4-projects@FreeBSD.ORG Sat Mar 18 17:23:44 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 5BECD16A424; Sat, 18 Mar 2006 17:23:44 +0000 (UTC) X-Original-To: perforce@FreeBSD.org Delivered-To: perforce@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3A08916A420; Sat, 18 Mar 2006 17:23:44 +0000 (UTC) (envelope-from arr@watson.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 66F3A43D48; Sat, 18 Mar 2006 17:23:43 +0000 (GMT) (envelope-from arr@watson.org) Received: from fledge.watson.org (localhost.watson.org [127.0.0.1]) by fledge.watson.org (8.13.4/8.13.4) with ESMTP id k2IHOqFx017248; Sat, 18 Mar 2006 12:24:52 -0500 (EST) (envelope-from arr@watson.org) Received: from localhost (arr@localhost) by fledge.watson.org (8.13.4/8.13.4/Submit) with ESMTP id k2IHOq99017245; Sat, 18 Mar 2006 12:24:52 -0500 (EST) (envelope-from arr@watson.org) X-Authentication-Warning: fledge.watson.org: arr owned process doing -bs Date: Sat, 18 Mar 2006 12:24:52 -0500 (EST) From: "Andrew R. Reiter" To: Robert Watson In-Reply-To: <20060318170636.E578@fledge.watson.org> Message-ID: <20060318122340.O51324@fledge.watson.org> References: <200603181701.k2IH1r5x004312@repoman.freebsd.org> <20060318120450.C51324@fledge.watson.org> <20060318170636.E578@fledge.watson.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Perforce Change Reviews Subject: Re: PERFORCE change 93511 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Mar 2006 17:23:44 -0000 On Sat, 18 Mar 2006, Robert Watson wrote: : :On Sat, 18 Mar 2006, Andrew R. Reiter wrote: : :> Heh; you just read my mind (was about to email) : :If you get bored, you should come hang out in #trustedbsd on EFNet so that we :can perform more feats of mind-reading :-). :-) Not a bad idea. Been out of the computer zone for awhile ... decided to go part time and work on photography and videography so I'm feeling a bit more "excited" to work on projects; at least in any minor way. Thanks for the tip. I hope all is well and that life is treating you good. Cheers, Andrew : :Robert N M Watson : :> :> On Sat, 18 Mar 2006, Robert Watson wrote: :> :> :http://perforce.freebsd.org/chv.cgi?CH=93511 :> : :> :Change 93511 by rwatson@rwatson_peppercorn on 2006/03/18 17:01:32 :> : :> : When pulling the global audit queue's contents into a thread-local :> : queue, generate one low water mark transition signal, rather than :> : many, and generate it only if actually crossing the transition :> : point, rather than every time we notice we're below it. :> : :> :Affected files ... :> : :> :.. //depot/projects/trustedbsd/audit3/sys/security/audit/audit.c#21 edit :> : :> :Differences ... :> : :> :==== //depot/projects/trustedbsd/audit3/sys/security/audit/audit.c#21 :> (text+ko) ==== :> : :> :@@ -555,7 +555,7 @@ :> : struct ucred *audit_cred; :> : struct thread *audit_td; :> : struct vnode *audit_vp; :> :- int error; :> :+ int error, lowater_signal; :> : :> : AUDIT_PRINTF(("audit_worker starting\n")); :> : :> :@@ -607,13 +607,16 @@ :> : * our own clustering, if the lower layers aren't doing it :> : * automatically enough. :> : */ :> :+ lowater_signal = 0; :> : while ((ar = TAILQ_FIRST(&audit_q))) { :> : TAILQ_REMOVE(&audit_q, ar, k_q); :> : audit_q_len--; :> :- if (audit_q_len <= audit_qctrl.aq_lowater) :> :- cv_broadcast(&audit_commit_cv); :> :+ if (audit_q_len == audit_qctrl.aq_lowater) :> :+ lowater_signal++; :> : TAILQ_INSERT_TAIL(&ar_worklist, ar, k_q); :> : } :> :+ if (lowater_signal) :> :+ cv_broadcast(&audit_commit_cv); :> : :> : mtx_unlock(&audit_mtx); :> : while ((ar = TAILQ_FIRST(&ar_worklist))) { :> : :> : :> :> -- :> arr@watson.org :> : : -- arr@watson.org