From owner-cvs-src@FreeBSD.ORG Fri Dec 2 13:28:48 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0AD6216A41F; Fri, 2 Dec 2005 13:28:48 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 852C143D55; Fri, 2 Dec 2005 13:28:47 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id E4D7046BEB; Fri, 2 Dec 2005 08:28:46 -0500 (EST) Date: Fri, 2 Dec 2005 13:28:46 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: John Baldwin In-Reply-To: <200512020749.06435.jhb@freebsd.org> Message-ID: <20051202132726.L77687@fledge.watson.org> References: <200510271539.j9RFdJdS096434@repoman.freebsd.org> <20051202114031.J77687@fledge.watson.org> <200512020749.06435.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, "David E. O'Brien" Subject: Re: cvs commit: src/sys/dev/nve if_nve.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2005 13:28:48 -0000 On Fri, 2 Dec 2005, John Baldwin wrote: >> I have had at least one report that this patch corrects repeated >> wedging of the if_nve interface on 6.x systems. Do you have plans to >> merge this patch to RELENG_6 and/or RELENG_6_0? The PR seems to >> suggest a larger set of changes that I've not dug into, and as a result >> fail to understand, however. > > I'd be interested in looking at the PR FWIW as I've been doing some > hacking on nve(4) recently. After some discussion, it sounds like the problem here is that this patch fixes a bug in a workaround for other serious problems -- i.e., that when you reset the interface to deal with the fact that the interface has wedged, it isn't being properly reset. So this patch is useful, in that it helps work around one or more other serious bugs better, but still leaves serious underlying problems. That said, I think it would be good to MFC the fix. Robert N M Watson