Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 Jun 2001 19:13:23 -0400
From:      Bosko Milekic <bmilekic@technokratis.com>
To:        Alfred Perlstein <bright@sneakerz.org>
Cc:        Jordan Hubbard <jkh@osd.bsdi.com>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/dev/lge if_lge.c src/sys/dev/nge if_nge.c src/sys/dev/vx if_vx.c src/sys/kern uipc_mbuf.c src/sys/pci if_dc.c if_rl.c if_sf.c if_sis.c if_sk.c if_vr.c if_wb.c
Message-ID:  <20010620191323.A37042@technokratis.com>
In-Reply-To: <20010620174316.O4543@sneakerz.org>; from bright@sneakerz.org on Wed, Jun 20, 2001 at 05:43:16PM -0500
References:  <20010620162727.K4543@sneakerz.org> <20010620174149.A36453@technokratis.com> <20010620170145.N4543@sneakerz.org> <20010620151043X.jkh@osd.bsdi.com> <20010620174316.O4543@sneakerz.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Wed, Jun 20, 2001 at 05:43:16PM -0500, Alfred Perlstein wrote:
> What is sounds like is:
> 
> pre new m_devget:
>   m_devget(off = 0,...) == m_devget(off = 15, ...)

	What? Huh? No, this is wrong.

	m_devget(off = 15, ...) pre new m_devget is broken.
 
> post new m_devget:
>   m_devget(off = 0,...) != m_devget(off = 15, ...)
>
> which means that someone inadvertantly passing non-zero off will get
> zapped by this change.
> 
> which is what I'm objecting to.  if the above guess is wrong then
> there's really no problem, but it sure doesn't sound like i'm wrong.
> 
> -Alfred
> 

-- 
 Bosko Milekic
 bmilekic@technokratis.com


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010620191323.A37042>