From owner-cvs-src@FreeBSD.ORG Fri Nov 5 13:12:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E89316A4CE; Fri, 5 Nov 2004 13:12:49 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id E70BB43D1F; Fri, 5 Nov 2004 13:12:48 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id iA5DEn4O031328; Fri, 5 Nov 2004 06:14:49 -0700 (MST) (envelope-from scottl@freebsd.org) Message-ID: <418B7C92.5000005@freebsd.org> Date: Fri, 05 Nov 2004 06:13:54 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <200411050905.iA595Gct083808@repoman.freebsd.org> In-Reply-To: <200411050905.iA595Gct083808@repoman.freebsd.org> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/geom/mirror g_mirror.c g_mirror.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2004 13:12:49 -0000 Pawel Jakub Dawidek wrote: > pjd 2004-11-05 09:05:15 UTC > > FreeBSD src repository > > Modified files: > sys/geom/mirror g_mirror.c g_mirror.h > Log: > MFp4: > - Fix for good (I hope) force-stopping mirrors and some filure cases > (e.g. the last good component dies when synchronization is in progress). > Don't use ->nstart/->nend consumer's fields, as this could be racy, > because those fields are used in g_down/g_up, use ->index consumer's > field instead for tracking number of not finished requests. > > Reported by: marcel > > - After 5 seconds of idle time (this should be configurable) mark all > dirty providers as clean, so when mirror is not used in 5 seconds > and there will be power failure, no synchronization on boot is needed. > > Idea from: sorry, I can't find who suggested this Do you check that all outstanding writes are actually completed in this timeout period, or just that you haven't recieved any new writes in this period? Scott