Date: Tue, 1 Aug 2017 20:13:54 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org>, freebsd-current@FreeBSD.org Cc: Ngie Cooper <yaneurabeya@gmail.com> Subject: Re: zfs.ko no longer loads after r320156: unresolved symbol: abd_is_linear Message-ID: <ae25a840-ee61-e86b-a933-3d93c0dd1fd2@FreeBSD.org> In-Reply-To: <79082534.uzyizLL08l@ralph.baldwin.cx> References: <780A67EE-C3F1-46E5-A213-E253B710338E@gmail.com> <d948a8c3-7bdb-e4cf-40e0-5e148b58554a@FreeBSD.org> <79082534.uzyizLL08l@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/08/2017 19:21, John Baldwin wrote:
> On Tuesday, August 01, 2017 09:47:41 AM Andriy Gapon wrote:
>> On 01/08/2017 02:31, Ngie Cooper wrote:
>>> Hi,
>>> I tried upgrading my host from 11.1-STABLE to 12.0-CURRENT, and it didn’t work because abd_is_linear is an undefined symbol (it exists in sys/conf/files, but not sys/modules/zfs/Makefile). I tried adding abd.c to sys/modules/zfs/Makefile and it didn’t immediately fix my compilation problem (ran into a linker error instead).
>>> If it isn’t fixed in the next few hours I’ll try my hand at fixing the problem.
>>
>> I am not sure what exact problem you have...
>> abd.c should be added to the list of source files via
>> .include "${SUNW}/uts/common/Makefile.files"
>>
>> Perhaps something to do with "inline"...
>
> Oh, yes. If you use -fno-inline-funcs or the like. I forgot to
> send this to Andriy earlier, but here is the fix I'm using:
>
> https://github.com/freebsd/freebsd/commit/574dc95cf8272e16f6d44aff6cb4e08dede08886
>
Please commit at your convenience.
I'll make sure that the fix is upstreamed as well.
Thank you!
--
Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ae25a840-ee61-e86b-a933-3d93c0dd1fd2>