From owner-freebsd-net@FreeBSD.ORG  Sat Jun 21 16:00:17 2014
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 23C68267
 for <net@freebsd.org>; Sat, 21 Jun 2014 16:00:17 +0000 (UTC)
Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 049972DC2
 for <net@freebsd.org>; Sat, 21 Jun 2014 16:00:17 +0000 (UTC)
Received: from [192.168.200.204] (c-50-131-5-126.hsd1.ca.comcast.net
 [50.131.5.126])
 (using SSLv3 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 (Authenticated sender: sbruno@ignoranthack.me)
 by mail.ignoranthack.me (Postfix) with ESMTPSA id 235BF1936DE;
 Sat, 21 Jun 2014 16:00:16 +0000 (UTC)
Subject: Re: getpeername returning ENOTCONN for a connected socket
From: Sean Bruno <sbruno@ignoranthack.me>
Reply-To: sbruno@freebsd.org
To: hiren panchasara <hiren.panchasara@gmail.com>
In-Reply-To: <CALCpEUFq1pVBjLjLV+88-qnjcKOM6vbw9SjOkhGdFYoT8Qsgcw@mail.gmail.com>
References: <CALCpEUFq1pVBjLjLV+88-qnjcKOM6vbw9SjOkhGdFYoT8Qsgcw@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
Date: Sat, 21 Jun 2014 09:00:15 -0700
Message-ID: <1403366415.39384.11.camel@bruno>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 7bit
Cc: "freebsd-net@freebsd.org" <net@freebsd.org>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Jun 2014 16:00:17 -0000

On Fri, 2014-06-20 at 16:21 -0700, hiren panchasara wrote:
> Reviving an old thread where Steve found this problem: A call to
> getpeername on a connected tcp socket returns ENOTCONN with no prior
> errors being reported by previous socket calls.
> 
> Please look at http://lists.freebsd.org/pipermail/freebsd-net/2011-January/027647.html
> for more details.
> 
> Here is a proposed patch derived from
> $src/sys/netsmb/smb_trantcp.c:nbssn_recv()'s way of handling a similar
> situation:
> 
> Index: sys/kern/uipc_syscalls.c
> ===================================================================
> --- sys/kern/uipc_syscalls.c    (revision 267693)
> +++ sys/kern/uipc_syscalls.c    (working copy)
> @@ -1755,6 +1755,12 @@
>         if (error != 0)
>                 return (error);
>         so = fp->f_data;
> +       if ((so->so_state & (SS_ISDISCONNECTED|SS_ISDISCONNECTING)) ||
> +           (so->so_rcv.sb_state & SBS_CANTRCVMORE)) {
> +               error = ECONNRESET;
> +               goto done;
> +       }
>         if ((so->so_state & (SS_ISCONNECTED|SS_ISCONFIRMING)) == 0) {
>                 error = ENOTCONN;
>                 goto done;
> 
> Does this look correct?
> 
> cheers,
> Hiren

Has this been tested in "anger" anywhere?

sean