From owner-svn-src-all@FreeBSD.ORG Mon Apr 18 22:26:53 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3DD83106566C; Mon, 18 Apr 2011 22:26:53 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id EC4918FC18; Mon, 18 Apr 2011 22:26:52 +0000 (UTC) Received: by pzk27 with SMTP id 27so3015840pzk.13 for ; Mon, 18 Apr 2011 15:26:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=w95NYcDnay39c9LUnC2Q1hiVSVRsHnAiABMIxVUVpiI=; b=tTm5GKpgqNM5aKYO1XvZDvY83G5jTjDYPxA7A0rf0fv9eclWO03pDnLrw/ITs9Mxwp PNjKD8yf0FnAqfpDpQQ3rZoSLz1OF5/TPZz/bNc87ddLiHzPjx/3huLc0xWOuJeGqlSb 9EARXFBNXrR4vQWyQr9TXkUqpv4zuzfdsmHCw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=wmiLZpVScIR2/+vsU6E2NuLwix9ikouKsJaQCZYU3R94i00Ob7DHU4P0VXNS+HVRcB 2mcmE3xTMJkDn8JypdryrUxFrtyUeRh5f9dyojOJwTZof6xe8b89fLxEJwew8H8xGOxq H9X2gTvw4fdsM5N4D3zr8Ib53RCZVgl3126Ho= MIME-Version: 1.0 Received: by 10.68.2.132 with SMTP id 4mr7558747pbu.11.1303165612635; Mon, 18 Apr 2011 15:26:52 -0700 (PDT) Received: by 10.68.42.3 with HTTP; Mon, 18 Apr 2011 15:26:52 -0700 (PDT) In-Reply-To: <4DACB0C3.6000804@FreeBSD.org> References: <201104170605.p3H65cab028890@svn.freebsd.org> <20110418181314.GL16958@FreeBSD.org> <4DACB0C3.6000804@FreeBSD.org> Date: Mon, 18 Apr 2011 15:26:52 -0700 Message-ID: From: Garrett Cooper To: Maxim Sobolev Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Gleb Smirnoff , src-committers@freebsd.org Subject: Re: svn commit: r220736 - head/sbin/natd X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 22:26:53 -0000 2011/4/18 Maxim Sobolev : > On 4/18/2011 11:13 AM, Gleb Smirnoff wrote: >> >> This looks like a hack and better place for this hack would be shell >> scripts rather than nat daemon. > > Well, I am not sure how would you apply shell script in such case. The > problem with the original code is that natd just silently exits, leaving > machine without a network connection. For some reason this problem started > after upgrade from 7.4 to 8.2, perhaps there is some changes in the dhclient > which allows it to run is parallel with other start-up activity. I've seen the problem that you've attempted to fix here before at home, and it actually occurred between 8.1 and 8.2. I merely hacked things to work at home in the rc script because I didn't want to muck around with natd's C sources. > And I don't see any problem with natd waiting indefinitely on the interface > to acquire IP address, it's no better and no worse than the current behavior > when the natd simply bails out. If it does this when backgrounded, that seems ok. If it blocks foregrounded like this, that's not acceptable. Thanks, -Garrett