From owner-svn-src-all@FreeBSD.ORG Thu Jun 3 13:41:55 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5AB2C106567A; Thu, 3 Jun 2010 13:41:55 +0000 (UTC) (envelope-from trasz@FreeBSD.org) Received: from svn.freebsd.org (unknown [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 4A8EC8FC2C; Thu, 3 Jun 2010 13:41:55 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o53DftYJ094271; Thu, 3 Jun 2010 13:41:55 GMT (envelope-from trasz@svn.freebsd.org) Received: (from trasz@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o53DftKm094269; Thu, 3 Jun 2010 13:41:55 GMT (envelope-from trasz@svn.freebsd.org) Message-Id: <201006031341.o53DftKm094269@svn.freebsd.org> From: Edward Tomasz Napierala Date: Thu, 3 Jun 2010 13:41:55 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r208779 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jun 2010 13:41:55 -0000 Author: trasz Date: Thu Jun 3 13:41:55 2010 New Revision: 208779 URL: http://svn.freebsd.org/changeset/base/208779 Log: The acl_cnt field is unsigned; no point in checking if it's >= 0. Found with: Coverity Prevent CID: 3683 Modified: head/sys/kern/subr_acl_nfs4.c Modified: head/sys/kern/subr_acl_nfs4.c ============================================================================== --- head/sys/kern/subr_acl_nfs4.c Thu Jun 3 13:04:56 2010 (r208778) +++ head/sys/kern/subr_acl_nfs4.c Thu Jun 3 13:41:55 2010 (r208779) @@ -342,7 +342,6 @@ acl_nfs4_sync_acl_from_mode(struct acl * const int WRITE = 02; const int EXEC = 01; - KASSERT(aclp->acl_cnt >= 0, ("aclp->acl_cnt >= 0")); KASSERT(aclp->acl_cnt <= ACL_MAX_ENTRIES, ("aclp->acl_cnt <= ACL_MAX_ENTRIES"));