Date: Fri, 26 Feb 2021 16:59:36 +0000 From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-approval requested: [Bug 253870] devel/libgtop: fails to build on head after commit 2bfd8992c7c7 : [Attachment 222851] Patch using sys/types.h Message-ID: <bug-253870-6497-KJNR12ETPi@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-253870-6497@https.bugs.freebsd.org/bugzilla/> References: <bug-253870-6497@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
Guido Falsi <madpilot@FreeBSD.org> has asked freebsd-gnome (Nobody) <gnome@FreeBSD.org> for maintainer-approval: Bug 253870: devel/libgtop: fails to build on head after commit 2bfd8992c7c7 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253870 Attachment 222851: Patch using sys/types.h https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D222851&action=3Dedit --- Comment #3 from Guido Falsi <madpilot@FreeBSD.org> --- Created attachment 222851 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D222851&action= =3Dedit Patch using sys/types.h I'm using a slightly different patch. Actually that bool type should be the one expected by kernel own sources, w= hich is defined in types.h Hoisting it's inclusion and forcing _KERNEL defined warrants the correct includes. I'm not able to judge which one is the best approach. Obviously I'm biased towards my own patch :)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-253870-6497-KJNR12ETPi>