From owner-svn-src-all@freebsd.org Mon Feb 12 14:47:14 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A8BB5F206D3; Mon, 12 Feb 2018 14:47:14 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-lf0-f50.google.com (mail-lf0-f50.google.com [209.85.215.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 079B777909; Mon, 12 Feb 2018 14:47:13 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-lf0-f50.google.com with SMTP id c188so4864702lfc.11; Mon, 12 Feb 2018 06:47:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ucVJSM6UGyd9QQ4tiq2aYv33Vt0pf/utJtsQzKXFWfU=; b=s+4KP3n/tQzBHgVBRwJsYnOeuKfa+8GTZ03JoUXHhrCWy/a1iuicyozllxRT19BDW7 /5WOwmZv5ux8nmhf1Qf/yoApeg5caBC29kCD478SimKrkTAl32aXggXTA4/oxKV2ErGU VGucrHl+82Zzv09HhAgD97lzGup2+MOuw/zixiIlYozp/pH7EpH037t+960JJEVD5cdV DIligSGdJvjZfsWYzQNB42j/nvVM9H0m2C6mAVUidUPEMeMXbVRbnUGsMA3LgBesWmDT zUToQqP4yjiX4qOHxB10YMaG1nYWYIi3Erg8pi7EASvdqyoylohFqQJGhWWr17kSqkQc A+qw== X-Gm-Message-State: APf1xPBLdKBwVJC7FkoGKXaRB2htHh6yhHtSL0bVWCqVG/7ue2HioKpz f20bGQ7XxMs5w78XlSXgojzOE20B X-Google-Smtp-Source: AH8x22642EBYBvRDQoO2VUJoHgxgmMMdpkafvqFrn9RY9XomLkfkCx2eoSopdT4nuLKfgAscOdyLZw== X-Received: by 10.46.101.208 with SMTP id e77mr5074715ljf.66.1518446825562; Mon, 12 Feb 2018 06:47:05 -0800 (PST) Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com. [209.85.215.51]) by smtp.gmail.com with ESMTPSA id p189sm1724557lfe.64.2018.02.12.06.47.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 06:47:05 -0800 (PST) Received: by mail-lf0-f51.google.com with SMTP id t79so20779399lfe.3; Mon, 12 Feb 2018 06:47:04 -0800 (PST) X-Received: by 10.25.157.141 with SMTP id g135mr7124091lfe.142.1518446824160; Mon, 12 Feb 2018 06:47:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.46.106.8 with HTTP; Mon, 12 Feb 2018 06:46:43 -0800 (PST) In-Reply-To: <201712211221.vBLCLZ5p017820@repo.freebsd.org> References: <201712211221.vBLCLZ5p017820@repo.freebsd.org> From: Kyle Evans Date: Mon, 12 Feb 2018 08:46:43 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r327058 - head/stand/efi/boot1 To: Michael Zhilin Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, tsoome@freebsd.org, Allan Jude Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2018 14:47:14 -0000 On Thu, Dec 21, 2017 at 6:21 AM, Michael Zhilin wrote: > Author: mizhka > Date: Thu Dec 21 12:21:35 2017 > New Revision: 327058 > URL: https://svnweb.freebsd.org/changeset/base/327058 > > Log: > [boot/efi] scan all display modes rather than sequential try-fail way > > This patch allows to scan all display modes in boot1 as loader does. > > Before system tried to select optimal display mode by sequential scan of > modes and if error then stop scanning. This way is not good, because > if mode N is not present, mode N+1 may exist. > > In loader we use conout->Mode->MaxMode to identify maximum number of modes. > This commit is to use same way in boot1 as in loader. > > Reported by: Andrey Pustovetov > Reviewed by: tsoome > Differential Revision: https://reviews.freebsd.org/D13541 > HI, Just FYI- we've had several reports of this doing the wrong thing for many people, most recently by Allan yesterday (IIRC). I'm going to avoid MFC'ing it, I think we should either back this out or figure out where it's going wrong sooner rather than later. =( Thanks, Kyle Evans