Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 05 Jul 2013 12:00:19 +0300
From:      Andriy Gapon <avg@FreeBSD.org>
To:        Jia-Shiun Li <jiashiun@gmail.com>
Cc:        Konstantin Belousov <kostikbel@gmail.com>, freebsd-hackers@FreeBSD.org
Subject:   Re: cpufreq not working as module on i386/amd64
Message-ID:  <51D68B23.1020104@FreeBSD.org>
In-Reply-To: <CAHNYxxM%2B%2BgCFS=H%2Bvc6hWYPXkYBp%2Bw29cwL_zdHTVjU824_w_w@mail.gmail.com>
References:  <AANLkTi=Ln7f9tWt=OqZa9eZ-ZAVBfQSC-y_=8c-6zwAd@mail.gmail.com> <20110129084125.GA54969@freebsd.org> <CAHNYxxPZMUMDMBo0tRSSjJZWqDD7BNR7BdadcVfZk5nDHS2c1A@mail.gmail.com> <CAHNYxxOCDMzumJS9S9=tmrwdjunrp6wsH5TOgLO6EEU9OAkhaQ@mail.gmail.com> <20130108150155.GF82219@kib.kiev.ua> <CAHNYxxM%2B%2BgCFS=H%2Bvc6hWYPXkYBp%2Bw29cwL_zdHTVjU824_w_w@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
on 04/07/2013 08:37 Jia-Shiun Li said the following:
> ok anyone can help test and review this patch?

I can not bless this change, but I won't argue against it either.

My opinion is still that OS should advertise to ACPI the capabilities that it
actually has not those that it potentially may have.  So I prefer the status
quo.  I think that this is a minor issue and cpufreq should just be in kernel,
and that's it.

> It will allow cpufreq to be removed from kernel conf, loaded and
> function correctly as kernel module. I've tested it ok on my own
> i5-3450.
> 
> It removes get_features method definition from acpi_if.m and
> corresponding implementations from est, p4tcc, & hwpstate. Feature
> flags are set directly in acpi_cpu.c omitting previous procedure of
> querying cpufreq drivers.
> 
> 
> After this, I'd like to find some ways to feed CPU loading info
> directly in kernel to cpufreq for finer & quicker control of
> frequencies.


-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51D68B23.1020104>