From owner-freebsd-bugs@FreeBSD.ORG  Sun Oct 31 09:40:33 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5224A16A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 31 Oct 2004 09:40:33 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2489D43D1D
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 31 Oct 2004 09:40:33 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i9V9eXd1027612
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 31 Oct 2004 09:40:33 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i9V9eXft027611;
	Sun, 31 Oct 2004 09:40:33 GMT
	(envelope-from gnats)
Resent-Date: Sun, 31 Oct 2004 09:40:33 GMT
Resent-Message-Id: <200410310940.i9V9eXft027611@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Jacques Vidrine <nectar@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A5C8B16A4CE
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sun, 31 Oct 2004 09:34:21 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9679243D46
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sun, 31 Oct 2004 09:34:21 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i9V9YLlU048125
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 31 Oct 2004 09:34:21 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id i9V9YLjG048124;
	Sun, 31 Oct 2004 09:34:21 GMT
	(envelope-from nobody)
Message-Id: <200410310934.i9V9YLjG048124@www.freebsd.org>
Date: Sun, 31 Oct 2004 09:34:21 GMT
From: Jacques Vidrine <nectar@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Subject: misc/73337: nsswitch: potential invalid free
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 31 Oct 2004 09:40:33 -0000


>Number:         73337
>Category:       misc
>Synopsis:       nsswitch: potential invalid free
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 31 09:40:32 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Jacques Vidrine
>Release:        5.3-STABLE
>Organization:
FreeBSD
>Environment:
FreeBSD madman.celabo.org 5.3-STABLE FreeBSD 5.3-STABLE #5: Mon Oct 18 20:11:13 CDT 2004     root@madman.celabo.org:/usr/obj/usr/src/sys/MADMAN  i386
>Description:
Date: Wed, 27 Oct 2004 09:33:33 +0200                                                            
From: Danny Braniss <danny@cs.huji.ac.il>                                                        
To: bushman@rsu.ru                                                                               
Cc: hackers@freebsd.org, "Jacques A. Vidrine" <nectar@freebsd.org>,                                      "Christian S.J. Peron" <csjp@freebsd.org>                                                
Subject: Re: nsdispatch services patch + lookupd                                                 
Message-Id: <20041027073335.8B74343D55@mx1.FreeBSD.org>                                             

while trying to add hesiod/dns support, i've noticed, what looks as a problem:

in nss_tls.h, the function name##_getstate(...) can return a static pointer,
which gets freed in name##_endstate(...), as far as i know, freeing a non
malloced memory is asking for trouble.
proposed fix, instead of static, also do a calloc(...).

danny
>How-To-Repeat:
      
>Fix:
make jacques work on it
>Release-Note:
>Audit-Trail:
>Unformatted: