From owner-freebsd-bugs  Sat May 12 18:50: 7 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id EDD6737B43E
	for <freebsd-bugs@hub.freebsd.org>; Sat, 12 May 2001 18:50:00 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f4D1o0217088;
	Sat, 12 May 2001 18:50:00 -0700 (PDT)
	(envelope-from gnats)
Received: from dannyboy.worksforfood.com (adsl-207-68-84-132.chlstn.adsl.bellatlantic.net [207.68.84.132])
	by hub.freebsd.org (Postfix) with ESMTP id A644D37B424
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 12 May 2001 18:47:09 -0700 (PDT)
	(envelope-from dannyboy@worksforfood.com)
Received: by dannyboy.worksforfood.com (Postfix, from userid 1000)
	id 17AFD5A56B; Sat, 12 May 2001 21:47:54 -0400 (EDT)
Message-Id: <20010513014754.17AFD5A56B@dannyboy.worksforfood.com>
Date: Sat, 12 May 2001 21:47:54 -0400 (EDT)
From: dannyboy@freebsd.org
Reply-To: dannyboy@freebsd.org
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.113
Subject: bin/27294: pkg_update disregards suffixes (portrevision, portepoch)
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         27294
>Category:       bin
>Synopsis:       pkg_update disregards suffixes (portrevision, portepoch)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 12 18:50:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Daniel Harris
>Release:        FreeBSD 4.3-STABLE i386
>Organization:
>Environment:
System: FreeBSD dannyboy.worksforfood.com 4.3-STABLE FreeBSD 4.3-STABLE #10: Sat Apr 28 02:45:35 EDT 2001 root@dannyboy.worksforfood.com:/usr/obj/usr/src/sys/INDEPENDENCE i386


	
>Description:
	pkg_update does not handle suffixes (portrevision and portepoch)
	correctly.  foo-1.2.3_4 is seen as foo-1.2.3 .
>How-To-Repeat:
	
>Fix:

	I have no idea what I'm doing, much less if this is the correct
	solution.  Please take a look before committing anything.

Index: pkg_update.pl
===================================================================
RCS file: /home/ncvs/src/usr.sbin/pkg_install/update/pkg_update.pl,v
retrieving revision 1.4
diff -u -r1.4 pkg_update.pl
--- pkg_update.pl	2001/01/14 02:05:02	1.4
+++ pkg_update.pl	2001/05/13 00:55:18
@@ -52,7 +52,7 @@
 sub get_version($) {
 	my ($pkg) = @_;
 
-	$pkg =~ /(.+)-([0-9\.]+)/;
+	$pkg =~ /(.+)-([0-9(?\.|_|,)]+)/;
 	if (! $2) {
 		return($pkg, "");
 	} else {
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message