From owner-svn-src-head@FreeBSD.ORG Wed Dec 23 08:00:23 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7532C1065676; Wed, 23 Dec 2009 08:00:23 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id F27658FC0A; Wed, 23 Dec 2009 08:00:22 +0000 (UTC) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.3/8.14.3/ALCHEMY.FRANKEN.DE) with ESMTP id nBN80LZ5012593; Wed, 23 Dec 2009 09:00:21 +0100 (CET) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.3/8.14.3/Submit) id nBN80Lg9012592; Wed, 23 Dec 2009 09:00:21 +0100 (CET) (envelope-from marius) Date: Wed, 23 Dec 2009 09:00:21 +0100 From: Marius Strobl To: John Baldwin Message-ID: <20091223080021.GJ74529@alchemy.franken.de> References: <200912222102.nBML2k98076576@svn.freebsd.org> <200912221720.00692.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200912221720.00692.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r200874 - in head/sys: dev/auxio sparc64/central sparc64/ebus sparc64/fhc sparc64/pci sparc64/sbus sparc64/sparc64 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Dec 2009 08:00:23 -0000 On Tue, Dec 22, 2009 at 05:20:00PM -0500, John Baldwin wrote: > On Tuesday 22 December 2009 4:02:46 pm Marius Strobl wrote: > > Author: marius > > Date: Tue Dec 22 21:02:46 2009 > > New Revision: 200874 > > URL: http://svn.freebsd.org/changeset/base/200874 > > > > Log: > > Enroll these drivers in multipass probing. The motivation behind this > > is that the JBus to EBus bridges share the interrupt controller of a > > sibling JBus to PCIe bridge (at least as far as the OFW device tree > > is concerned, in reality they are part of the same chip) so we have to > > probe and attach the latter first. That happens to be also the case > > due to the fact that the JBus to PCIe bridges appear first in the OFW > > device tree but it doesn't hurt to ensure the right order. > > Hmm, I'm curious why you used BUS_PASS_DEFAULT with EARLY_DRIVER_MODULE()? > The intent was that EARLY_DRIVER_MODULE() only really be used for drivers that > used a pass other than BUS_PASS_DEFAULT. Just in order to document as good as possible that the use of another pass level has been considered but was decided to not be the right thing to do (although dma_sbus(4) can act like a bus BUS_PASS_BUS isn't appropriate for example) as my impression was that at some point in time we'll want to got through the tree and change for example all bus drivers to use BUS_PASS_BUS etc similarly to how BUS_PROBE_* at least partially was introduced in a sweeping fashion (causing the expected breakage). Marius