Date: Mon, 18 May 2015 15:03:28 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: Dirk Meyer <dirk.meyer@dinoex.sub.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Antoine Brodin <antoine@FreeBSD.org> Subject: Re: svn commit: r386439 - head/Mk Message-ID: <555A3780.6010508@FreeBSD.org> In-Reply-To: <eBlUNY/VHR@dmeyer.dinoex.sub.org> References: <201505151704.t4FH4sP9055425@svn.freebsd.org> <eBlUNY/VHR@dmeyer.dinoex.sub.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 05/18/2015 00:54, Dirk Meyer wrote:
> hi Jung-uk Kim, hi Antoine Brodin,
>
> Jung-uk Kim schrieb:,
>
>> Log: - Do not define OPENSSLRPATH when base OpenSSL is used.
>> Adding /usr/lib is pointless and blindly adding ${LOCALBASE}/lib
>> after that is even harmful. - Stop hardcoding "pkg query". [1]
>>
>> PR: 200164 [1] Approved by: portmgr (antoine) Exp-run by:
>> antoine
>>
>> Modified: head/Mk/bsd.openssl.mk
>>
>
> Sorry, but /usr/lib is not pointless at all, it was added to fix
> runtime problems.
>
> This will break in current, wherre the shlib versions in base and
> port match.
...
No, it should never match unless a user has stale binaries or ports
tree. FYI, base is 7 and ports is 8.
Conversely, adding /usr/lib to rpath is very harmful in some cases.
For example, when a port wants GCC from ports but it is also available
from base, we were never able to set USE_OPENSSL=yes because
bsd.openssl.mk added /usr/lib to LDFLAGS and friends *before*
bsd.gcc.mk does. It caused ABI conflict and runtime crash. In other
words, USE_GCC and USE_OPENSSL can co-exist after this commit. :-)
Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJVWjd7AAoJEHyflib82/FGAxAH/0BiEQ0a9TOMfFoOq+kxbwWz
hf/8yemSTvJWgtSp5PZZPNRh6SQODAbav1jIu5rAz36t7rREZtKyLh/J+QLJExKg
wPNlRhYRgL/MJPfzZf54P5nUW65GHnGOWEv/k8oY1aCPpmhVDgLmwcISS2MIYCT6
4rAnA2zkllOZ9M/q6uuD/yct20eggFj36hTMTHLENRD2bcGPFuB4+axsU/CKboda
17RDUsDyKR3MqFdsAx6f9alOqKSBWr71hn/TZZC5d1jwaAN9+DFVgMLmfaItQRPA
nT/rhLfiAXrI6kEcBy+RX0lmGNg5njrcq2FNqVllauvdk7NoAXD2jMAO9I57UCY=
=KSvu
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?555A3780.6010508>