From owner-svn-src-all@FreeBSD.ORG Tue Dec 2 17:15:09 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 12BB71065673; Tue, 2 Dec 2008 17:15:09 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id B54998FC13; Tue, 2 Dec 2008 17:15:08 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 9144341C711; Tue, 2 Dec 2008 18:15:06 +0100 (CET) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id Psx0qMBwwu+g; Tue, 2 Dec 2008 18:15:06 +0100 (CET) Received: by mail.cksoft.de (Postfix, from userid 66) id 3D05041C70C; Tue, 2 Dec 2008 18:15:06 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 538DA4448D5; Tue, 2 Dec 2008 17:15:00 +0000 (UTC) Date: Tue, 2 Dec 2008 17:15:00 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Sam Leffler In-Reply-To: <493568EE.20609@freebsd.org> Message-ID: <20081202170528.S80401@maildrop.int.zabbadoz.net> References: <200812020445.mB24jXaS048636@svn.freebsd.org> <20081202064345.S80401@maildrop.int.zabbadoz.net> <493568EE.20609@freebsd.org> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Paul Saab Subject: Re: svn commit: r185544 - head/sys/modules/ae X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Dec 2008 17:15:09 -0000 On Tue, 2 Dec 2008, Sam Leffler wrote: Hi, > Bjoern A. Zeeb wrote: >> On Tue, 2 Dec 2008, Paul Saab wrote: >> >>> Author: ps >>> Date: Tue Dec 2 04:45:33 2008 >>> New Revision: 185544 >>> URL: http://svn.freebsd.org/changeset/base/185544 >>> >>> Log: >>> Fix world by including opt_route.h >> >> Where did world fail for you? >> >> I assume what failed was a single direct module build? Per discussion >> on current@ we are working on this but it's a long list of files with >> awkward dependencies to go through. >> >> If that was the only problem, the manual module build, please let me >> know so I can back this out again as soon as the vimage header files >> are untangled. > Note I added explicit opt_route.h to all the ath-related modules because I > hit problems too. I must've missed the discussion on current@. No problem and thanks for the note. I have removed them all and then readded the ones still (really) needed. The universe that is currently building doesn't have them in ath*/Makefiles and ae/Makefile anymore. Did a make depend in sys/modules/ and after the initial untangling we are down from ~390 to 14 modules still inlcuding vnet.h and thus depending on opt_route.h A veriosn of the patch is here: http://people.freebsd.org/~bz/20081202-v-h-06.diff There is more cleanup to follow afterwards. I also found quite a few other spots going through more >100 files... but that's initally unrelated and in my general "INET cleanup" pigeonhole. /bz -- Bjoern A. Zeeb Stop bit received. Insert coin for new game.