Date: Tue, 30 Apr 2013 18:40:01 GMT
From: Hiroki Sato <hrs@FreeBSD.org>
To: freebsd-ports-bugs@FreeBSD.org
Subject: Re: ports/178250: Fix build failures of japanese/{mozc-server, mozc-tool, ibus-mozc, mozc-el}
Message-ID: <201304301840.r3UIe15W005646@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/178250; it has been noted by GNATS.
From: Hiroki Sato <hrs@FreeBSD.org>
To: abtk@shitamachi.org
Cc: freebsd-gnats-submit@FreeBSD.org, hrs@FreeBSD.org
Subject: Re: ports/178250: Fix build failures of japanese/{mozc-server,
mozc-tool, ibus-mozc, mozc-el}
Date: Wed, 01 May 2013 03:36:08 +0900 (JST)
----Security_Multipart(Wed_May__1_03_36_08_2013_641)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Tadaaki Nagao <abtk@shitamachi.org> wrote
in <20130501.012308.420345141091390850.abtk@shitamachi.org>:
ab> When I wrote the patch I previously sent, my intention was to preserve
ab> original code as much as possible. As for why they were so written in
ab> the first place, please ask the original author... (daichi-san?)
I am also not sure why, but they simply shouldn't have been
committed. The previous change is fairly broken as you noticed. We
do not have to preserve the wrong part.
ab> But I agree with you that those BUILD_DEPENDS should be got rid of in
ab> favor of some other preferable ways. I will look into this, but it will
ab> take some time because Mozc's build system looks to me too complicated
ab> to understand. In the meanwhile, how about applying my patch as a quick
ab> fix for the current breakage, and having refinements later as a second
ab> step.
I already submitted a similar fix. Can you review it?
http://people.allbsd.org/~hrs/FreeBSD/mozc_port_20130428-2.diff (patch)
http://people.allbsd.org/~hrs/FreeBSD/mozc_port_full_20130428-2.tar.gz (tarball of the patched ports)
Although I received a build error report in some environment and
still investigating it, this should fix wrong parts (including style
clean-ups) as far as I can see.
-- Hiroki
----Security_Multipart(Wed_May__1_03_36_08_2013_641)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (FreeBSD)
iEYEABECAAYFAlGADxgACgkQTyzT2CeTzy3ibgCfT1MCo+6nd7reFluTXkPqzu1z
cFkAoKSdpPQjATaj2eHG4ArNqDJukbXV
=u58M
-----END PGP SIGNATURE-----
----Security_Multipart(Wed_May__1_03_36_08_2013_641)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201304301840.r3UIe15W005646>