From owner-cvs-src-old@FreeBSD.ORG Mon Mar 22 11:01:20 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 09C97106564A for ; Mon, 22 Mar 2010 11:01:20 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id ED1298FC12 for ; Mon, 22 Mar 2010 11:01:19 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o2MB1JPZ002355 for ; Mon, 22 Mar 2010 11:01:19 GMT (envelope-from des@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o2MB1J4b002354 for cvs-src-old@freebsd.org; Mon, 22 Mar 2010 11:01:19 GMT (envelope-from des@repoman.freebsd.org) Message-Id: <201003221101.o2MB1J4b002354@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to des@repoman.freebsd.org using -f From: Dag-Erling Smorgrav Date: Mon, 22 Mar 2010 11:00:57 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/openpam/include/security pam_appl.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2010 11:01:20 -0000 des 2010-03-22 11:00:57 UTC FreeBSD src repository Modified files: contrib/openpam/include/security pam_appl.h Log: SVN rev 205441 on 2010-03-22 11:00:57Z by des Merge upstream r432: pam_end() already contains a NULL check, and it is not unreasonable to call it with a NULL pamh in a cleanup / error-handling situation. Remove OPENPAM_NONNULL, which may cause gcc to optimize away the NULL check. This fixes a potential NULL pointer dereference in error-handling code in passwd(1). Revision Changes Path 1.2 +44 -27 src/contrib/openpam/include/security/pam_appl.h