From owner-freebsd-current@FreeBSD.ORG Thu Mar 1 12:56:55 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0B7AE16A403 for ; Thu, 1 Mar 2007 12:56:55 +0000 (UTC) (envelope-from freebsd-current@dino.sk) Received: from bsd.dino.sk (bsd.dino.sk [213.215.72.60]) by mx1.freebsd.org (Postfix) with ESMTP id 87F7913C442 for ; Thu, 1 Mar 2007 12:56:54 +0000 (UTC) (envelope-from freebsd-current@dino.sk) Received: from fox.dino.sk (home.dino.sk [84.245.95.252]) (AUTH: PLAIN milan, TLS: TLSv1/SSLv3,256bits,AES256-SHA) by bsd.dino.sk with esmtp; Thu, 01 Mar 2007 13:58:19 +0100 id 00000073.45E6CDEB.000173BA From: Milan Obuch To: freebsd-current@freebsd.org Date: Thu, 1 Mar 2007 13:55:42 +0100 User-Agent: KMail/1.9.5 References: <200703010829.18334.freebsd-current@dino.sk> <20070301080449.GO11232@hoeg.nl> In-Reply-To: <20070301080449.GO11232@hoeg.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200703011355.43119.freebsd-current@dino.sk> Subject: Re: /etc/make.conf oddity (?) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Mar 2007 12:56:55 -0000 On Thursday 01 March 2007 09:04, Ed Schouten wrote: > Hello Milan, > > * Milan Obuch wrote: > > I put KERNCONF="FOX" into my /etc/make.conf, make buildkernel in /usr/src > > tells ERROR: Missing kernel configuration file(s) (FOX). > > > > If I change it into KERNCONF=FOX, no error message and build works as if > > command make buildkernel KERNCONF=FOX were given. > > > > My understanding was variable values should be enclosed in quotes, did I > > missread or missinterpret something? > > > > Even if it is no real issue (read: could not find simple workaround), I > > would like to know if it's me or not. > > I once had this issue as well. Keep in mind that /etc/make.conf is a > Makefile, not a shellscript. In Makefiles you don't need to quote your > variables. In shell scripts you do, because the second argument will be > treated as a command. > > Yours, Thanks, so it was me... I am going tp remove all quotes for the sake of consistency, as I think in WITHOUT_foo="YES" and WITHOUT_foo=YES have both the same effect - all that's checked is if variable is defined and real value is unimportant. But it would be easier to avoid such errors this way... Regards, Milan -- Address this mail is sent from is used only for this mailing list. Do not send any messages to it directly as a response, reply only to mailing list. For mail to me personally, use milan in address instead.