From owner-svn-src-head@freebsd.org Fri Dec 21 18:38:10 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 235051353524; Fri, 21 Dec 2018 18:38:10 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7E168770A7; Fri, 21 Dec 2018 18:38:09 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-lj1-x22b.google.com with SMTP id s5-v6so5567354ljd.12; Fri, 21 Dec 2018 10:38:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=NFLLjTzBdx1FJ0oSOeMG0cvhg0zzKXMjtBxMXyUHBNw=; b=HlLzVjrFFHxx8RS/Iy6bb2D/OPxRUcFGUIZiPGLOHpEyyjr3aH3lrZERy9U8iwXWzl eUAA9F8NaC9aralqsd2U0Gtm8muBVFB6y6xyLmSzOQsbfgsyS1lnrvqYLoBBDOZtMvSY NBm+kC1wyMJlJmrRstXz6Q7ZDqCQ6y2Ukv8S5OfKXOZu6R/KE4a0hsKYso3gJIkivmOW ZFGbJNE1Kkmca1h92t9rx2ZukLXKb/9QUYb92tYs5vfL5yY1XnN81qDDJWfX+YJzdcWu YiVy9Cw7od5b5nUP8Qe2afzVDkAR0G2ImgfQSh3klpUw67l+wUKnGE4MFcq+W2yTzc7u 5FBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=NFLLjTzBdx1FJ0oSOeMG0cvhg0zzKXMjtBxMXyUHBNw=; b=ShTGhVUjdoS0zN4kmKAPIZEIS5cwe+hcZAJVZKuQ5fMH97tHnWfdJeiKZEz2sDcOk1 XDJpW1P+ukz2GtvOaE/prJFib5G2ZHCln61wi8ryJTDrJ8TVk/SeKib+72ID+kDslKey LzkRZyhRn1RABiZaXMoGCf1xgSvsOr6ASuAKAihQ1UC3q/0NOUecotHeembqDyrNKpvV 38f786FxEojHJhntdCK8mDYGs6Wwqy9OtXu6w03d+I8WoRQzqvmh96zNUjVzCUbXLgV+ bSmR3a//vx8lJv9sHs2Ei8jO9BV12WKWzhtegip0heoRTDHb+26oU9D/M9Oeww7rr+5g IXzA== X-Gm-Message-State: AJcUukekD4IviMursxqfyalJFzjeCnqGUL4wkyYwi3VOFLrLLc9F5Jgf zO3tkzDlk4x4U08apCmGzryzN1y3+mi8aMQG9vMoPg== X-Google-Smtp-Source: ALg8bN7Yi7wqfzeEN1h05Dzu8/7Fe3xUpvhiGElqCNy8RrdLmRWDi1LPtUD4eyapldGZKgT3QabE3PVqk7thU+ao8CE= X-Received: by 2002:a2e:5c07:: with SMTP id q7-v6mr2433712ljb.119.1545417487687; Fri, 21 Dec 2018 10:38:07 -0800 (PST) MIME-Version: 1.0 References: <201812211722.wBLHMF3V011619@repo.freebsd.org> In-Reply-To: <201812211722.wBLHMF3V011619@repo.freebsd.org> Reply-To: araujo@freebsd.org From: Marcelo Araujo Date: Sat, 22 Dec 2018 02:37:55 +0800 Message-ID: Subject: Re: svn commit: r342349 - head/usr.sbin/ctladm To: Alexander Motin Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 7E168770A7 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.985,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 18:38:10 -0000 Em s=C3=A1b, 22 de dez de 2018 =C3=A0s 01:22, Alexander Motin escreveu: > Author: mav > Date: Fri Dec 21 17:22:15 2018 > New Revision: 342349 > URL: https://svnweb.freebsd.org/changeset/base/342349 > > Log: > Fix passing wrong variables to nvlist_destroy() after r333446. > > Reported by: Alexander Fedorov (IT-Grad.ru) > MFC after: 5 days > Thanks to fix that! Out of curiosity, that was reported by email, bugzilla or any other place? Best, > > Modified: > head/usr.sbin/ctladm/ctladm.c > > Modified: head/usr.sbin/ctladm/ctladm.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.sbin/ctladm/ctladm.c Fri Dec 21 17:18:33 2018 > (r342348) > +++ head/usr.sbin/ctladm/ctladm.c Fri Dec 21 17:22:15 2018 > (r342349) > @@ -667,7 +667,7 @@ cctl_port(int fd, int argc, char **argv, char *combin= e > } > > bailout: > - nvlist_destroy(req.args_nvl); > + nvlist_destroy(option_list); > free(driver); > return (retval); > > @@ -2542,7 +2542,7 @@ cctl_create_lun(int fd, int argc, char **argv, char > *c > fprintf(stdout, "Device ID: %s\n", > req.reqdata.create.device_id); > > bailout: > - nvlist_destroy(req.args_nvl); > + nvlist_destroy(option_list); > return (retval); > } > > @@ -2644,7 +2644,7 @@ cctl_rm_lun(int fd, int argc, char **argv, char > *combi > printf("LUN %d removed successfully\n", lun_id); > > bailout: > - nvlist_destroy(req.args_nvl); > + nvlist_destroy(option_list); > return (retval); > } > > @@ -2764,7 +2764,7 @@ cctl_modify_lun(int fd, int argc, char **argv, char > *c > printf("LUN %d modified successfully\n", lun_id); > > bailout: > - nvlist_destroy(req.args_nvl); > + nvlist_destroy(option_list); > return (retval); > } > > > --=20 --=20 Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)