From owner-freebsd-gnome@FreeBSD.ORG Wed Feb 19 18:40:01 2014 Return-Path: Delivered-To: gnome@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A1DAADB0 for ; Wed, 19 Feb 2014 18:40:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8DBA41600 for ; Wed, 19 Feb 2014 18:40:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s1JIe1IH057189 for ; Wed, 19 Feb 2014 18:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s1JIe1Pr057188; Wed, 19 Feb 2014 18:40:01 GMT (envelope-from gnats) Date: Wed, 19 Feb 2014 18:40:01 GMT Message-Id: <201402191840.s1JIe1Pr057188@freefall.freebsd.org> To: gnome@FreeBSD.org From: Tijl Coosemans Subject: Re: ports/186846: [patch] converters/libiconv: compilation with -Oz broken X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: Tijl Coosemans List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Feb 2014 18:40:01 -0000 The following reply was made to PR ports/186846; it has been noted by GNATS. From: Tijl Coosemans To: bug-followup@FreeBSD.org Cc: Subject: Re: ports/186846: [patch] converters/libiconv: compilation with -Oz broken Date: Wed, 19 Feb 2014 19:32:28 +0100 --MP_/a1dP7fDT.6pF01Msx5erdEj Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Updated patch which adds a DOCS option and includes changes from http://www.freebsd.org/cgi/query-pr.cgi?pr=186590 --MP_/a1dP7fDT.6pF01Msx5erdEj Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=libiconv.patch Index: converters/libiconv/Makefile =================================================================== --- converters/libiconv/Makefile (revision 345014) +++ converters/libiconv/Makefile (working copy) @@ -3,24 +3,24 @@ PORTNAME= libiconv PORTVERSION= 1.14 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= converters devel MASTER_SITES= GNU MAINTAINER= gnome@FreeBSD.org -COMMENT= A character set conversion library +COMMENT= Character set conversion library GNU_CONFIGURE= yes CONFIGURE_ARGS= --enable-static \ --without-libintl-prefix \ --docdir=${DOCSDIR} -CONFIGURE_ENV= gl_cv_cc_visibility="no" \ - am_cv_func_iconv="yes" \ +CONFIGURE_ENV= am_cv_func_iconv="yes" \ am_cv_proto_iconv_arg1="const" MAKE_JOBS_UNSAFE= yes +USE_CSTD= gnu89 USE_LDCONFIG= yes -OPTIONS_DEFINE= ENCODINGS PATCHES +OPTIONS_DEFINE= DOCS ENCODINGS PATCHES OPTIONS_DEFAULT=ENCODINGS ENCODINGS_DESC= Include extra character sets PATCHES_DESC= Apply patches to fix CP932, add EUCJP-MS Index: converters/libiconv/files/patch-lib-iconv.c =================================================================== --- converters/libiconv/files/patch-lib-iconv.c (revision 0) +++ converters/libiconv/files/patch-lib-iconv.c (working copy) @@ -0,0 +1,11 @@ +--- lib/iconv.c.orig ++++ lib/iconv.c +@@ -598,7 +598,7 @@ + It wants to define the symbols 'iconv_open', 'iconv', 'iconv_close'. */ + #define strong_alias(name, aliasname) _strong_alias(name, aliasname) + #define _strong_alias(name, aliasname) \ +- extern __typeof (name) aliasname __attribute__ ((alias (#name))); ++ extern LIBICONV_DLL_EXPORTED __typeof (name) aliasname __attribute__ ((alias (#name))); + #undef iconv_open + #undef iconv + #undef iconv_close Property changes on: converters/libiconv/files/patch-lib-iconv.c ___________________________________________________________________ Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Index: converters/libiconv/pkg-plist =================================================================== --- converters/libiconv/pkg-plist (revision 345014) +++ converters/libiconv/pkg-plist (working copy) @@ -17,10 +17,10 @@ man/man3/iconv_open.3.gz man/man3/iconv_open_into.3.gz man/man3/iconv_close.3.gz man/man3/iconvctl.3.gz -%%DOCSDIR%%/iconv.1.html -%%DOCSDIR%%/iconv.3.html -%%DOCSDIR%%/iconv_close.3.html -%%DOCSDIR%%/iconv_open.3.html -%%DOCSDIR%%/iconv_open_into.3.html -%%DOCSDIR%%/iconvctl.3.html -@dirrm %%DOCSDIR%% +%%PORTDOCS%%%%DOCSDIR%%/iconv.1.html +%%PORTDOCS%%%%DOCSDIR%%/iconv.3.html +%%PORTDOCS%%%%DOCSDIR%%/iconv_close.3.html +%%PORTDOCS%%%%DOCSDIR%%/iconv_open.3.html +%%PORTDOCS%%%%DOCSDIR%%/iconv_open_into.3.html +%%PORTDOCS%%%%DOCSDIR%%/iconvctl.3.html +%%PORTDOCS%%@dirrm %%DOCSDIR%% --MP_/a1dP7fDT.6pF01Msx5erdEj--