From owner-svn-src-head@FreeBSD.ORG Wed Mar 4 03:30:21 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DB075106564A; Wed, 4 Mar 2009 03:30:21 +0000 (UTC) (envelope-from das@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id C9B1D8FC08; Wed, 4 Mar 2009 03:30:21 +0000 (UTC) (envelope-from das@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n243ULff030288; Wed, 4 Mar 2009 03:30:21 GMT (envelope-from das@svn.freebsd.org) Received: (from das@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n243ULV5030287; Wed, 4 Mar 2009 03:30:21 GMT (envelope-from das@svn.freebsd.org) Message-Id: <200903040330.n243ULV5030287@svn.freebsd.org> From: David Schultz Date: Wed, 4 Mar 2009 03:30:21 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r189348 - head/lib/libc/gen X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2009 03:30:22 -0000 Author: das Date: Wed Mar 4 03:30:21 2009 New Revision: 189348 URL: http://svn.freebsd.org/changeset/base/189348 Log: Fix a file descriptor leak in fts_child(). Obtained from: NetBSD Modified: head/lib/libc/gen/fts.c Modified: head/lib/libc/gen/fts.c ============================================================================== --- head/lib/libc/gen/fts.c Wed Mar 4 03:22:03 2009 (r189347) +++ head/lib/libc/gen/fts.c Wed Mar 4 03:30:21 2009 (r189348) @@ -570,8 +570,10 @@ fts_children(sp, instr) if ((fd = _open(".", O_RDONLY, 0)) < 0) return (NULL); sp->fts_child = fts_build(sp, instr); - if (fchdir(fd)) + if (fchdir(fd)) { + (void)_close(fd); return (NULL); + } (void)_close(fd); return (sp->fts_child); }