From owner-freebsd-net@freebsd.org Tue Mar 23 11:26:54 2021 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8A1695AB597 for ; Tue, 23 Mar 2021 11:26:54 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4F4Tbf0Szzz4jd0; Tue, 23 Mar 2021 11:26:53 +0000 (UTC) (envelope-from gnn@neville-neil.com) X-Originating-IP: 108.46.224.187 Received: from [192.168.4.205] (pool-108-46-224-187.nycmny.fios.verizon.net [108.46.224.187]) (Authenticated sender: gnn@neville-neil.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 56E3C2000B; Tue, 23 Mar 2021 11:26:49 +0000 (UTC) From: "George Neville-Neil" To: "Alan Somers" Cc: "Kevin Bowling" , "FreeBSD Net" , "Michael Tuexen" , rscheff@freebsd.org Subject: Re: tcp-testsuite into src? Date: Tue, 23 Mar 2021 07:26:48 -0400 X-Mailer: MailMate (1.14r5757) Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4F4Tbf0Szzz4jd0 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2021 11:26:54 -0000 On 22 Mar 2021, at 22:45, Alan Somers wrote: > On Mon, Mar 22, 2021 at 7:31 PM Kevin Bowling > wrote: > >> Hi, >> >> I was talking with gnn and kevans on IRC about the tcp testsuite >> (https://github.com/freebsd-net/tcp-testsuite). >> >> Currently we maintain this in ports, although the way the port is set >> up doesn't make a lot of sense because the tests are stack specific >> and we don't account for different FreeBSD versions let alone vendor >> trees. It seems reasonable to me to pull the tests themselves (i.e. >> https://github.com/freebsd-net/tcp-testsuite) into src where they can >> follow along with the tree they are running on, and provide vendors a >> natural point of extension. >> >> /usr/tests has some existing examples of relying on out of tree >> binaries to run so I am not convinced we need to import packetdrill >> itself but I don't have a strong preference. tuexen, do you have any >> preference? >> >> Regards, >> Kevin >> _______________________________________________ >> freebsd-net@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-net >> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >> > > Yeah, it's not a problem to use binaries from ports in /usr/tests. As long > as the tests can compile they can live in the base system. Is there a > strong incentive to import them? Do they need to be adjusted for each > release? I found out this morning that moving the tests into base is indeed the plan: https://wiki.freebsd.org/TransportProtocols/11March2021 I'm happy to see this happen. The next step will be documentation of how to add new/good tests to the suite. Best, George