From owner-svn-src-all@freebsd.org Mon Dec 12 19:13:02 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AC0B2C733E3; Mon, 12 Dec 2016 19:13:02 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3DE0C7F2; Mon, 12 Dec 2016 19:13:02 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wm0-x242.google.com with SMTP id u144so13229534wmu.0; Mon, 12 Dec 2016 11:13:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=fj0D+rHjO6d6ZF3ovxeb56nJ36aNZcj6fWbebI21+N4=; b=lXiD88V7ehIDg+j1jwMdw1EJb4NM7f8uYFd/OSRxExHMk3/N9pBv4wdLwTgSgb5Lyv 5H2X6Wekd+iuUtg19QxiHovno4RnNncgasIDVu8aQ1CZr/J1qvD93y4/QPQM3LVsXs25 9Ed2Qt+m6/JDK2s1IcC/TIZqLgi5og/fjSBcz1ulhMbEaRiwGqzcWauvk2zgy5Kso4Ki x24G/rpdgnYHycffCnKYCnYbWBM6LEpi0kkZh5C+nSp/Zp5jVG6nonyff+43AdvcvyWS MhtINFpuH2jxElDALYGfTQqPYgZkCz4fipEgVU4BBX1JVRn+TY7WonTt6Upb4yPX0o58 NFZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=fj0D+rHjO6d6ZF3ovxeb56nJ36aNZcj6fWbebI21+N4=; b=VTZgW6EcH8ntfgDC2/9TSahP7IrqP9T80gc5NpavUXwYlTc8OET79iv8xfAZlUAlTI WIBovSYTzOfy/aMF6cMFh5YprmmYAFU+zJ3b7TmjtyfM674/cozSnuh/0c97/LZZ+9OZ 1lPU1za45XDdP6QUUxyjzfggJe5zLjkpnBhPP9YEiSE5fhfMMyyvXC20PbPx1GWH92rB BeP4yl7wOyc9EViD3qeXXrnSi7+yb92gLhBKQ/BvT0T4Ms++84FnwVH8e2KQA5BsBJiy dzvVYD1VLgThvloiaZIEaXTFEHhD7sjSwdREiwAula9YU0n8Cu6kV9U1UFiX/fCmKiAo qkHg== X-Gm-Message-State: AKaTC03uuix5EO/JNny+bo3mMI9TcqylWLp7xpReaLdMXlFwiGKNCYkvKvidCQemoxKkNA== X-Received: by 10.28.74.133 with SMTP id n5mr10306064wmi.132.1481569980688; Mon, 12 Dec 2016 11:13:00 -0800 (PST) Received: from brick (aegh224.neoplus.adsl.tpnet.pl. [79.186.163.224]) by smtp.gmail.com with ESMTPSA id d85sm36822694wmd.17.2016.12.12.11.12.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Dec 2016 11:13:00 -0800 (PST) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Mon, 12 Dec 2016 20:12:57 +0100 From: Edward Tomasz Napierala To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r309891 - head/sys/kern Message-ID: <20161212191257.GA11238@brick> Mail-Followup-To: Konstantin Belousov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201612121522.uBCFMMmm088698@repo.freebsd.org> <20161212163331.GH54029@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161212163331.GH54029@kib.kiev.ua> User-Agent: Mutt/1.7.1 (2016-10-04) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Dec 2016 19:13:02 -0000 On 1212T1833, Konstantin Belousov wrote: > On Mon, Dec 12, 2016 at 03:22:22PM +0000, Edward Tomasz Napierala wrote: > > Author: trasz > > Date: Mon Dec 12 15:22:21 2016 > > New Revision: 309891 > > URL: https://svnweb.freebsd.org/changeset/base/309891 > > > > Log: > > Avoid dereferencing NULL pointers in devtoname(). I've seen it panic, > > called from ufs_print() in DDB. > Calls from DDB should not panic even if accessing NULL pointers. Yeah, by "panic" I've meant the "reentering ddb" thing. It's not a panic per se, but still breaks eg "show lockedvnodes". > That said, I also do not think that this is the right place to change. > UFS um_dev should not be NULL for any active mount. After looking at this once again I agree. Looks like some kind of bug specific to my sources at that point of time. Backed off.