From owner-svn-src-all@FreeBSD.ORG Tue May 22 10:22:56 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 12870106566C; Tue, 22 May 2012 10:22:56 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 9928F8FC12; Tue, 22 May 2012 10:22:55 +0000 (UTC) Received: from ds4.des.no (smtp.des.no [194.63.250.102]) by smtp.des.no (Postfix) with ESMTP id 009D86AB9; Tue, 22 May 2012 10:22:54 +0000 (UTC) Received: by ds4.des.no (Postfix, from userid 1001) id 9A4869239; Tue, 22 May 2012 12:22:54 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Baptiste Daroussin References: <201205211331.q4LDVRvB060077@svn.freebsd.org> Date: Tue, 22 May 2012 12:22:54 +0200 In-Reply-To: <201205211331.q4LDVRvB060077@svn.freebsd.org> (Baptiste Daroussin's message of "Mon, 21 May 2012 13:31:27 +0000 (UTC)") Message-ID: <86likkpla9.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r235723 - in head: contrib/byacc tools/regression/usr.bin/yacc usr.bin/yacc usr.bin/yacc/test X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2012 10:22:56 -0000 Baptiste Daroussin writes: > Log: > Import byacc from invisible island, it brings us lots of compatibilitie= s with > bison, keeping full compatibility with our previous yacc > implementation. This commit broke the build, in large part because Baptiste tested with Clang instead of GCC, and GCC generates a warning when compiling the generated code. Baptiste has a patch ready to commit, currently undergoing review by myself and other interested parties. I chose not to ask Baptiste to revert the commit, because it is a complex commit that copies some files from a vendor branch into contrib and removes others from the usr.bin/yacc, and I wasn't sure that reverting it wouldn't cause trouble with merge tracking. Lessons learned: 1) always test a *stock* build before committing: % cd /usr/src && env __MAKE_CONF=3D/dev/null make buildworld 2) the contrib part and the usr.bin part should probably have been committed separately. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no