From owner-freebsd-bugs@FreeBSD.ORG  Fri Apr 16 10:20:03 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1897E16A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 16 Apr 2004 10:20:03 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 120E043D41
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 16 Apr 2004 10:20:03 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	i3GHK2bv009106	for <freebsd-bugs@freefall.freebsd.org>;
	Fri, 16 Apr 2004 10:20:02 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i3GHK2eI009105;
	Fri, 16 Apr 2004 10:20:02 -0700 (PDT)
	(envelope-from gnats)
Date: Fri, 16 Apr 2004 10:20:02 -0700 (PDT)
Message-Id: <200404161720.i3GHK2eI009105@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Radim Kolar <hsn@netmag.cz>
Subject: Re: kern/65402: patch: fflush() should not return error on readonly
	files
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Radim Kolar <hsn@netmag.cz>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Apr 2004 17:20:03 -0000

The following reply was made to PR kern/65402; it has been noted by GNATS.

From: Radim Kolar <hsn@netmag.cz>
To: Colin Percival <colin.percival@wadham.ox.ac.uk>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: kern/65402: patch: fflush() should not return error on readonly files
Date: Fri, 16 Apr 2004 18:47:32 +0200

 > FreeBSD's behavior here is consequently correct; any behaviour would be
 > correct.  Programs which rely upon fflush() not returning an error when
 > passed a file which is opened read-only are broken, and should be fixed.
 I agree with you that my problem application rely upon nonportable behaviour.
 This is not reason for not including this patch.
 
 My points for including this patch are:
 
 1) do not breaks ISO standard
 2) do not breaks existing apps
 3) improve FreeBSD source code compatibility with other OSes, because these OSes are doing the same.
 4) fixes problem with my application, which is large (10MB) and difficult to fix.
 
 In summary: This patch will make things better, not worse. I do not know
 about negative side-effects.
 
 Radim