From owner-svn-ports-head@freebsd.org Mon Aug 3 08:05:08 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2B403372713; Mon, 3 Aug 2020 08:05:08 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BKr5w0K3bz4SZm; Mon, 3 Aug 2020 08:05:08 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [IPv6:2a01:678:4:1::228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id C72E126AE3; Mon, 3 Aug 2020 08:05:07 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (aching.in.mat.cc [IPv6:2a01:678:42:0:5e80:b6ff:fe2c:99e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 44D9F942D81; Mon, 3 Aug 2020 08:05:05 +0000 (UTC) Date: Mon, 3 Aug 2020 10:05:04 +0200 From: Mathieu Arnold To: Alexey Dokuchaev Cc: Mathieu Arnold , Stefan E??er , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r543919 - head/astro/xearth/files Message-ID: <20200803080504.3kzs5n7iapg7sajb@aching.in.mat.cc> References: <202008011830.071IUpJC086718@repo.freebsd.org> <20200803075524.tvfjcaxbbdd7lwgo@aching.in.mat.cc> <20200803080034.GA74839@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6flyfetw4yetigbt" Content-Disposition: inline In-Reply-To: <20200803080034.GA74839@FreeBSD.org> X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2020 08:05:08 -0000 --6flyfetw4yetigbt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 03, 2020 at 08:00:34AM +0000, Alexey Dokuchaev wrote: > On Mon, Aug 03, 2020 at 09:55:24AM +0200, Mathieu Arnold wrote: > > On Sat, Aug 01, 2020 at 06:30:51PM +0000, Stefan E?er wrote: > > > New Revision: 543919 > > > URL: https://svnweb.freebsd.org/changeset/ports/543919 > > >=20 > > > Log: > > > Fix format: 2 missing commas after the longitude and white space in= the > > > name fields > >=20 > > Space in the name fields are there so that names not in the same > > location but close to one another do not overlap. I am not sure > > removing them is a great idea. >=20 > Abusing spaces for that matter is wrong; the port should be fixed instead > of relying on manual alignment with spaces. >=20 > Please do not taint raw data with its physical representation gimmicks. When given the choice between spending 5 seconds adding 3 spaces to make it look good, or spending a day fixing antique software, I will always choose 5 seconds (as I don't know C that much, or X programming at all, it would be more like at least a week). If you have the time to fix xearth, feel free to do it, but do not assume people will have the time, will, or knowledge required to do so. --=20 Mathieu Arnold --6flyfetw4yetigbt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAl8nxStfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgJt0A//alsFe3FVs5aL1KatDGrxzAXV+AX8VSfz5Krp675GaNdFD1aqlK3lLfB6 oEPgiyR3kTnNJu+Mhx0E10RO2NqyYzupZPISV7m7cZy5Gv1SjAKy9M8f1yCdHQnT InLyvmspvod2SIn+lNFDDsoKEn/oCmx6Uh9XMTl6Uw7f2geY6p8b08/CnrhZXbtN QlBVlLMOjaCsfoZrscMJW4tNYjJxSz6SvNc1T43JwMAaa/TjTNl61ttwszlsUvdG Cwb6OD5sDOU6atgVHGk9m+a0pDskiCYsXWtEOzhCTc458nD3ww9DkhBkd4v4jzhw 6pHPo5v3EChMnQX4w+YoOpw5EDx0rPBjzcMof/Yj+f8QybIT6pvAY5qzx5W/DhaT aoBbK6A3esD5+2XlgBC6ZIuvqLS4QVZK975aRGbu99IpJwU6CZH080jEyvIQFx/o gDiDmrTDhtLzR8ANTxaT80mgU3Qyz2zVaL/hdRX8wYag3b/L8dYatbi6LjnPbBSX icEEao5I23J5vSBN/NdiIVvnnsaY+opWhlsQkZ6sFLeWy2ip72oTR58wDYOx4MIW nseoydPeQbcZX5KVVPLHGL+TcFn8jFSO2D5WG0t/0XlbVl6w1e1IVXDvvNev773e CsyHwLzZ+VnyGmBj7OOldvZjEqzF/2RFf8InjROmfpXGWgebljE= =idTZ -----END PGP SIGNATURE----- --6flyfetw4yetigbt--