From owner-cvs-src-old@FreeBSD.ORG Mon Jun 7 18:29:34 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D4BA1065670 for ; Mon, 7 Jun 2010 18:29:34 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (unknown [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6AB388FC18 for ; Mon, 7 Jun 2010 18:29:34 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o57ITYWZ030680 for ; Mon, 7 Jun 2010 18:29:34 GMT (envelope-from rrs@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o57ITYs2030679 for cvs-src-old@freebsd.org; Mon, 7 Jun 2010 18:29:34 GMT (envelope-from rrs@repoman.freebsd.org) Message-Id: <201006071829.o57ITYs2030679@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to rrs@repoman.freebsd.org using -f From: Randall Stewart Date: Mon, 7 Jun 2010 18:29:10 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet sctp_indata.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2010 18:29:34 -0000 rrs 2010-06-07 18:29:10 UTC FreeBSD src repository Modified files: sys/netinet sctp_indata.c Log: SVN rev 208897 on 2010-06-07 18:29:10Z by rrs This fixes a BUG in the handling of the cum-ack calculation. We were only paying attention to the nr-mapping-array. Which seems to make sense on the surface, by definition things up to the cum-ack should be deliverable thus in the nr-mapping-array. However (there is always a gotcha) thats not true when it comes to large messages. The stack may hold the message while re-assembling it not not deliver it based on several thresholds. If that happens (which it would for smaller large messages) then the cum-ack is figured wrong. We now properly use both arrays in the cum-ack calculation. MFC after: 1 week. Revision Changes Path 1.83 +12 -7 src/sys/netinet/sctp_indata.c