Date: Sat, 13 Jun 2015 15:46:31 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Adrian Chadd <adrian@freebsd.org> Cc: "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: [rfc] add MK_TELNET_SSL as a build option Message-ID: <181503FC-ED51-4F8B-A900-53B51578E2C0@gmail.com> In-Reply-To: <CAJ-VmomwHuoTQV4cKjivbotn0iAec-=-Nnma10NnwCo54Gw_KQ@mail.gmail.com> References: <CAJ-VmomwHuoTQV4cKjivbotn0iAec-=-Nnma10NnwCo54Gw_KQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_618C496D-6111-4B62-AE81-F4BBD2B80512 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Jun 13, 2015, at 15:40, Adrian Chadd <adrian@freebsd.org> wrote: > Hi, >=20 > The wifi builds have a need for building telnet/telnetd without > ssl/kerberos in order to meet size constraints and to allow them to be > crunch=92ed. ... > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- contrib/telnet/libtelnet/misc-proto.h (revision 284291) > +++ contrib/telnet/libtelnet/misc-proto.h (working copy) > @@ -71,6 +71,11 @@ > /* > * These functions are imported from the application > */ > +/* > + * XXX TODO: turn into a function set that's passed in > + * from telnet/telnetd main(). That way it can be > + * built via crunchgen. > + */ What=92s the story behind the TODO? > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- lib/libtelnet/Makefile (revision 284291) > +++ lib/libtelnet/Makefile (working copy) > @@ -15,7 +15,7 @@ >=20 > WARNS?=3D 2 >=20 > -.if ${MK_OPENSSL} !=3D "no" > +.if ${MK_OPENSSL} !=3D "no" && ${MK_TELNET_SSL} !=3D =93no" Please reduce this to ${MK_TELNET_SSL} !=3D =93no=94 (here and = elsewhere). ${MK_OPENSSL} =3D=3D =93no=94 already handles setting this = knob in src.opts.mk, so there=92s no reason why you need to check both = knobs. Thanks! --Apple-Mail=_618C496D-6111-4B62-AE81-F4BBD2B80512 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVfLLHAAoJEMZr5QU6S73exegH/ibrlENrc3HBPaz/fjGzfKVd 5Jhe3TODAU2kWq7CepipD4LpZWZa3SBfzjZZIUXDDuop8m9Nucvojsb7qGKiaSiL P/XnSXFmCvuvbhiC0Ad/x9LH6y4pQHJ+gc4dL4sl7t1sT469H3JV5QLSeLjyjYNN dO+RxOCt+48InKuDNhEJyJa1oG8kpPUCYeU5+5yYLXfR5ePjSFUHz4j018EF9xs3 ILYXAVBz7EX/q2l4woZudy13QtOaJTim5r0NRKmuuqFGWdRQQbU9+H/vTft36N8X dxQpvoyXxTfyZsYQwM5A6LE4/fDMfs9HASQdx1aR/h7AYjLVGYELJ2VYtUixHvQ= =M6Xv -----END PGP SIGNATURE----- --Apple-Mail=_618C496D-6111-4B62-AE81-F4BBD2B80512--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?181503FC-ED51-4F8B-A900-53B51578E2C0>