From owner-freebsd-arch@FreeBSD.ORG Sat Jun 13 22:46:36 2015 Return-Path: Delivered-To: freebsd-arch@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D9AD6D33; Sat, 13 Jun 2015 22:46:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pd0-x22d.google.com (mail-pd0-x22d.google.com [IPv6:2607:f8b0:400e:c02::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AEEAC5F6; Sat, 13 Jun 2015 22:46:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by pdjm12 with SMTP id m12so46089083pdj.3; Sat, 13 Jun 2015 15:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :message-id:references:to; bh=6Ujz1ppmwZXAsxQOztUqnriDl/tGQ0aBf+fwxma3Tbk=; b=aHOA0ZrPs145QMJ8CU2cBy0PYIzZFbSWBxkBtaumkc5J9ehEqyJCpWgC2a271BVL/0 57udo6oeVGzWdW8j5QAESOTuSoKAhKwP2PFR8VbrUQ78R6Uf8p4tTHItpMoEYUEt+L5x 9c19QUgczER2BnDMIgWJhSv8PX6wFb6HniY6IQn+jnTDdRw16UdQB0BrsGmJzD+dXWh3 ifTCjdiFf9YG5r1JJuVDvmoy7m44VJ1qZgXSopgx9mvNdXpJDkQPrzkwtSLWV3UVnm1z TuJqyfwmWE7X21N3gVNfFRDZe0VloKrBuakQWI6ctPBd9VjDAF04GtkYko1gkSH6XnMW edfQ== X-Received: by 10.70.130.168 with SMTP id of8mr35219820pdb.131.1434235595165; Sat, 13 Jun 2015 15:46:35 -0700 (PDT) Received: from ?IPv6:2601:8:ab80:7d6:2434:29cc:2519:36ef? ([2601:8:ab80:7d6:2434:29cc:2519:36ef]) by mx.google.com with ESMTPSA id da2sm7624287pbb.57.2015.06.13.15.46.33 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 13 Jun 2015 15:46:34 -0700 (PDT) Subject: Re: [rfc] add MK_TELNET_SSL as a build option Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_618C496D-6111-4B62-AE81-F4BBD2B80512"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Garrett Cooper In-Reply-To: Date: Sat, 13 Jun 2015 15:46:31 -0700 Cc: "freebsd-arch@freebsd.org" Message-Id: <181503FC-ED51-4F8B-A900-53B51578E2C0@gmail.com> References: To: Adrian Chadd X-Mailer: Apple Mail (2.1878.6) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jun 2015 22:46:36 -0000 --Apple-Mail=_618C496D-6111-4B62-AE81-F4BBD2B80512 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Jun 13, 2015, at 15:40, Adrian Chadd wrote: > Hi, >=20 > The wifi builds have a need for building telnet/telnetd without > ssl/kerberos in order to meet size constraints and to allow them to be > crunch=92ed. ... > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- contrib/telnet/libtelnet/misc-proto.h (revision 284291) > +++ contrib/telnet/libtelnet/misc-proto.h (working copy) > @@ -71,6 +71,11 @@ > /* > * These functions are imported from the application > */ > +/* > + * XXX TODO: turn into a function set that's passed in > + * from telnet/telnetd main(). That way it can be > + * built via crunchgen. > + */ What=92s the story behind the TODO? > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- lib/libtelnet/Makefile (revision 284291) > +++ lib/libtelnet/Makefile (working copy) > @@ -15,7 +15,7 @@ >=20 > WARNS?=3D 2 >=20 > -.if ${MK_OPENSSL} !=3D "no" > +.if ${MK_OPENSSL} !=3D "no" && ${MK_TELNET_SSL} !=3D =93no" Please reduce this to ${MK_TELNET_SSL} !=3D =93no=94 (here and = elsewhere). ${MK_OPENSSL} =3D=3D =93no=94 already handles setting this = knob in src.opts.mk, so there=92s no reason why you need to check both = knobs. Thanks! --Apple-Mail=_618C496D-6111-4B62-AE81-F4BBD2B80512 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVfLLHAAoJEMZr5QU6S73exegH/ibrlENrc3HBPaz/fjGzfKVd 5Jhe3TODAU2kWq7CepipD4LpZWZa3SBfzjZZIUXDDuop8m9Nucvojsb7qGKiaSiL P/XnSXFmCvuvbhiC0Ad/x9LH6y4pQHJ+gc4dL4sl7t1sT469H3JV5QLSeLjyjYNN dO+RxOCt+48InKuDNhEJyJa1oG8kpPUCYeU5+5yYLXfR5ePjSFUHz4j018EF9xs3 ILYXAVBz7EX/q2l4woZudy13QtOaJTim5r0NRKmuuqFGWdRQQbU9+H/vTft36N8X dxQpvoyXxTfyZsYQwM5A6LE4/fDMfs9HASQdx1aR/h7AYjLVGYELJ2VYtUixHvQ= =M6Xv -----END PGP SIGNATURE----- --Apple-Mail=_618C496D-6111-4B62-AE81-F4BBD2B80512--