From owner-freebsd-usb@FreeBSD.ORG  Wed Nov 17 18:20:30 2004
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E908416A4DF
	for <freebsd-usb@hub.freebsd.org>;
	Wed, 17 Nov 2004 18:20:30 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D66C143D41
	for <freebsd-usb@hub.freebsd.org>;
	Wed, 17 Nov 2004 18:20:30 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id iAHIKUgM049591
	for <freebsd-usb@freefall.freebsd.org>; Wed, 17 Nov 2004 18:20:30 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id iAHIKUqW049590;
	Wed, 17 Nov 2004 18:20:30 GMT
	(envelope-from gnats)
Date: Wed, 17 Nov 2004 18:20:30 GMT
Message-Id: <200411171820.iAHIKUqW049590@freefall.freebsd.org>
To: freebsd-usb@FreeBSD.org
From: nivit@email.it (Nicola Vitale)
Subject: Re: kern/63837: [patch] USB: hid_is_collection() only looks for the
	first item
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Nicola Vitale <nivit@email.it>
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Nov 2004 18:20:31 -0000

The following reply was made to PR kern/63837; it has been noted by GNATS.

From: nivit@email.it (Nicola Vitale)
To: John Baldwin <jhb@FreeBSD.org>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: kern/63837: [patch] USB: hid_is_collection() only looks for the first item
Date: Wed, 17 Nov 2004 17:11:10 +0100

 Hello,
 
 > [John Baldwin, 2004-11-17T09:59:20-05::00]
 > So, I think that the first part of the patch (setting h.report_ID to zero) is 
 > not needed.  Basically, AFAICT, the effect of the patch is that 
 > hid_report_size() will now return the ID of the first device of a given kind 
 > rather than the last such device.
 
 I'm agree with you. But I can't understand how this patch to hid_report_size()
 can magically eliminate the bug in hid_is_collection(), which this PR originally
 referred to.
 The function hid_is_collection() never calls hid_report_size()
 directly or indirectly.
 
 Thanks, ciao.
 -- 
 Nicola S. Vitale
 nivit@email.it