From owner-svn-src-head@freebsd.org Tue Jul 19 22:13:56 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 603EFB9E9F7 for ; Tue, 19 Jul 2016 22:13:56 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm21.bullet.mail.bf1.yahoo.com (nm21.bullet.mail.bf1.yahoo.com [98.139.212.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 185131EB2 for ; Tue, 19 Jul 2016 22:13:56 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1468965602; bh=HOw0gpEXTSRcF4V++5k8G8Pb0aMbQyyjJUTKc91txdk=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=DFV7DXkuREnccsQ8VEEYGLm2Q4aIK6Je5+YX+5LM/1FbLlNhLn+KUl8UFhchEUaiXXXEHUdDy1jclBtafBH0EblztIb2xnJpVLr4UyMwjZCJ8nNXOmX9TW6TA6j7crUmmesyW7jstTIPYNVEW0b95t6t8RoJrIlqoM78+VEmCOLyCOPGFnriUXQ1rTjMRsFNy1+y8iEpfqRZ+qgciCTgaSZgK3ECDIf0vkpgr4QuKz451MNGz64C2TxMjcHl9GbNu/K5P9J2CCuUrkTtzJbDQdYVivmsZl4TUt/qtaRs8yu3n5dJOlP39K3TdE20+asSFwX2gXZZT/XHVFgh3MYPCw== Received: from [66.196.81.174] by nm21.bullet.mail.bf1.yahoo.com with NNFMP; 19 Jul 2016 22:00:02 -0000 Received: from [68.142.230.64] by tm20.bullet.mail.bf1.yahoo.com with NNFMP; 19 Jul 2016 22:00:02 -0000 Received: from [127.0.0.1] by smtp221.mail.bf1.yahoo.com with NNFMP; 19 Jul 2016 22:00:02 -0000 X-Yahoo-Newman-Id: 845823.50913.bm@smtp221.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: NmP7zdIVM1lBVleoPpm22kzUqU6rjwSYQFbdphhp95Gy9iV XcY0U4Wk_ufgZSjhFpAPQEn_v9buopmTuEg2bMfdCNRZqYUTcP51MuWtITTq oy_M15fNWlU8QNQp1UmMZZwrh3CB3U5qiYqM12C2elxbuINZ6Dmk9fO4FTkw wZn2S0Mx6G2sukYjn4K1a3fFCdQvS7BBwYNRlNtpTj.9e2DHtLEv8W.2x0QP fftssXbC_1VIkWjG__.M82wcEG_EiMQlscLlBRCLjGc9RGgqHEZvwLJmeo7b QStO1bEuc9uW8UIgPDIHexJdDJPlAkwHREjobFfFmjPdn2piksOM3.IWPUyM 3x286eO2WB0SH9v8xRSi2F07LEUDaMxWna3WhwL7JD1aI7l8hRqhwssAUpk_ xIB7s_d1h1I9GKgYxSjr5b8yJzevVLn6ONmdIkJvHRIqW0wbEjVZOfsRzrZB 4nquQ34tizFKmm1Hcm8cd6fMocLUXoKeXTSLcYltxyvslJSEDqnxO_Oqm3h0 wVJhwsC6GfjQJ1bPYp2JnMO9H60E3TJIi8TEJ8t6rKlaagw-- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r303046 - head/lib/libc/locale To: Ed Schouten References: <201607192022.u6JKMDJD051361@repo.freebsd.org> <0273c74d-fc3b-8bf9-9c79-8bc8101943dc@FreeBSD.org> Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Pedro Giffuni Message-ID: Date: Tue, 19 Jul 2016 17:00:05 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <0273c74d-fc3b-8bf9-9c79-8bc8101943dc@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2016 22:13:56 -0000 On 07/19/16 16:22, Pedro Giffuni wrote: > Hi; > > On 07/19/16 15:46, Ed Schouten wrote: >> Hi Pedro, >> >> 2016-07-19 22:22 GMT+02:00 Pedro F. Giffuni : >>> Author: pfg >>> Date: Tue Jul 19 20:22:13 2016 >>> New Revision: 303046 >>> URL: https://svnweb.freebsd.org/changeset/base/303046 >>> >>> Log: >>> libc: tag the Rune initialization function prototypes visibility as >>> hidden. >> >> How does this interact with symbol versioning/mapping? Wouldn't our C >> library's symbol map already make these symbols hidden without any >> explicit annotation? >> > > It shouldn't hurt at all, this is not the first use that we make of the > visibility attributes in libc. I do notice we tend to put them at the > end of the prototype, while I followed the Apple notation of setting > them in front. No idea if that is worthwhile to change. > > It is true that these symbols should already be hidden but in the case > some port is using -fvisibility= compiler flag this will prevent the > symbols from getting exported by accident. > Hmm... actually, you probably can't unhide the regular functions with -fvisibility. It just doesn't hurt to have the extra insurance, plus it's generally not wrong to be compatible with Apple ;). Pedro.