Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Feb 2015 19:35:53 -0800
From:      Craig Rodrigues <rodrigc@FreeBSD.org>
To:        Gleb Smirnoff <glebius@freebsd.org>
Cc:        "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Nikos Vassiliadis <nvass@gmx.com>, "src-committers@freebsd.org" <src-committers@freebsd.org>
Subject:   Re: svn commit: r276747 - head/sys/netpfil/pf
Message-ID:  <CAG=rPVc2YLB-3ZyxDZTxDpkt6R8E_Sf1U%2BWWwKrFB2dxTXGENQ@mail.gmail.com>
In-Reply-To: <20150122222314.GO15484@FreeBSD.org>
References:  <201501060903.t06934qp081875@svn.freebsd.org> <20150122012709.GM15484@FreeBSD.org> <54C16715.6060701@gmx.com> <20150122222314.GO15484@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 22, 2015 at 2:23 PM, Gleb Smirnoff <glebius@freebsd.org> wrote:

> On Thu, Jan 22, 2015 at 10:09:41PM +0100, Nikos Vassiliadis wrote:
> N> > Sorry guys, I backed this out due to broken kldunload of pf module,
> which
> N> > is critical when you are working with pf bugs.
> N>
> N> For sure. 100% understood.
> N>
> N> > I had to backout r276746 as well, since it has numerous build
> breakages,
> N> > that are addressed by later revisions.
> N> >
> N> > That's my fault that I don't review in time, and I will try to improve
> N> > the situation.
> N> >
> N> > Can you please replay r276746 again, addressing all the build problems
> N> > and send the patch to me? You can user reviews.freebsd.org if you
> want.
> N> >
> N> > I'd like to get this in, but in a better quality.
> N>
> N> I'd like to get involved again and help you fixing pf. Craig could you
> N> replay 276746?
>



I wish you could have fixed the pf unload problem without backing out
all these changes.  I took all these changes from your projects/pf branch,
which was starting to bitrot because it was not being sync'd with head.

I got confirmation from several people that the fixes as they were (after
the build break fixes),
actually fixed their issues with PF and VIMAGE, which have been pending for
several
years now with no visible progress made.

Most regular users of PF don't really kldunload it once it is used.
For development use, I've been testing inside bhyve VM's, which doesn't
solve the kldunload problem but allows testing and forward progress.

Why do you want me to replay 276746 and give you a patch?

Why don't you just do it yourself?






--
Craig



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG=rPVc2YLB-3ZyxDZTxDpkt6R8E_Sf1U%2BWWwKrFB2dxTXGENQ>