From owner-svn-src-all@FreeBSD.ORG Sun Feb 15 03:35:57 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 04D65991; Sun, 15 Feb 2015 03:35:57 +0000 (UTC) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7F897F1F; Sun, 15 Feb 2015 03:35:56 +0000 (UTC) Received: by labgq15 with SMTP id gq15so23039445lab.3; Sat, 14 Feb 2015 19:35:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=enZG3N1I5VekPe9bsAe5sNeG+twd0CtUM1a/ANRUA7k=; b=bhLcvc5Fhbvo1gnzp0aXuVJj9DfpwcsXRRUnp8TU58rAf/K6FNHutUP8ufvxQEX40j B9lDTToK6bf5VPzwEgpYq7X1c3wSJCSEv6nHXEpbXh354csxIIrMmURF0PBrFe1gBrim 3PN5PJ9ZZTfpfToFH6U2/8jRFpGbTlSqqRz+04a90Ekdh6jqhdwD7XeBoS8O//es8at9 PloalaTTMUVNBiH9gSamfRUFio9jCQlZKsyhcjq2S5mfVkGqnq6gzCDF8j6w8gNOvVlt iQhRyJHK9KIGgKAxsUm3wM8nIzumDhGHYQVUoI1yNaSXJycqc4/rIapqnTUnmge7kK35 1kiA== MIME-Version: 1.0 X-Received: by 10.112.137.38 with SMTP id qf6mr15695103lbb.59.1423971354103; Sat, 14 Feb 2015 19:35:54 -0800 (PST) Sender: crodr001@gmail.com Received: by 10.112.28.40 with HTTP; Sat, 14 Feb 2015 19:35:53 -0800 (PST) In-Reply-To: <20150122222314.GO15484@FreeBSD.org> References: <201501060903.t06934qp081875@svn.freebsd.org> <20150122012709.GM15484@FreeBSD.org> <54C16715.6060701@gmx.com> <20150122222314.GO15484@FreeBSD.org> Date: Sat, 14 Feb 2015 19:35:53 -0800 X-Google-Sender-Auth: t0rvNHYDXy7BTh4VOMzJ4KFHvR4 Message-ID: Subject: Re: svn commit: r276747 - head/sys/netpfil/pf From: Craig Rodrigues To: Gleb Smirnoff Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Nikos Vassiliadis , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Feb 2015 03:35:57 -0000 On Thu, Jan 22, 2015 at 2:23 PM, Gleb Smirnoff wrote: > On Thu, Jan 22, 2015 at 10:09:41PM +0100, Nikos Vassiliadis wrote: > N> > Sorry guys, I backed this out due to broken kldunload of pf module, > which > N> > is critical when you are working with pf bugs. > N> > N> For sure. 100% understood. > N> > N> > I had to backout r276746 as well, since it has numerous build > breakages, > N> > that are addressed by later revisions. > N> > > N> > That's my fault that I don't review in time, and I will try to improve > N> > the situation. > N> > > N> > Can you please replay r276746 again, addressing all the build problems > N> > and send the patch to me? You can user reviews.freebsd.org if you > want. > N> > > N> > I'd like to get this in, but in a better quality. > N> > N> I'd like to get involved again and help you fixing pf. Craig could you > N> replay 276746? > I wish you could have fixed the pf unload problem without backing out all these changes. I took all these changes from your projects/pf branch, which was starting to bitrot because it was not being sync'd with head. I got confirmation from several people that the fixes as they were (after the build break fixes), actually fixed their issues with PF and VIMAGE, which have been pending for several years now with no visible progress made. Most regular users of PF don't really kldunload it once it is used. For development use, I've been testing inside bhyve VM's, which doesn't solve the kldunload problem but allows testing and forward progress. Why do you want me to replay 276746 and give you a patch? Why don't you just do it yourself? -- Craig