From owner-freebsd-ports@FreeBSD.ORG  Mon Sep 17 15:25:23 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9CAE4106564A;
	Mon, 17 Sep 2012 15:25:23 +0000 (UTC)
	(envelope-from bapt@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 66B5E8FC17;
	Mon, 17 Sep 2012 15:25:23 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q8HFPNP7049157;
	Mon, 17 Sep 2012 15:25:23 GMT (envelope-from bapt@FreeBSD.org)
Received: (from bapt@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q8HFPNAN049156;
	Mon, 17 Sep 2012 15:25:23 GMT (envelope-from bapt@FreeBSD.org)
X-Authentication-Warning: freefall.freebsd.org: bapt set sender to
	bapt@FreeBSD.org using -f
Date: Mon, 17 Sep 2012 17:25:20 +0200
From: Baptiste Daroussin <bapt@FreeBSD.org>
To: Anton Shterenlikht <mexas@bristol.ac.uk>
Message-ID: <20120917152520.GE13414@ithaqua.etoilebsd.net>
References: <201209171012.q8HACZZY029228@mech-cluster241.men.bris.ac.uk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="Lb0e7rgc7IsuDeGj"
Content-Disposition: inline
In-Reply-To: <201209171012.q8HACZZY029228@mech-cluster241.men.bris.ac.uk>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: mm@FreeBSD.org, freebsd-ports@FreeBSD.org
Subject: Re: [patch] --disable-jit for ia64 in devel/pcre
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Sep 2012 15:25:23 -0000


--Lb0e7rgc7IsuDeGj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 17, 2012 at 11:12:35AM +0100, Anton Shterenlikht wrote:
> devel/pcre fails on ia64 portscluster because defaults
> include JIT:
>=20
> http://pointyhat.freebsd.org/errorlogs/ia64-errorlogs/e.9.20120916093935/=
pcre-8.31.log
>=20
> This patch fixes it. I checked
> it on my own ia64 boxes:
>=20
> Index: Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- Makefile    (revision 304384)
> +++ Makefile    (working copy)
> @@ -32,7 +32,7 @@
> =20
>  .include <bsd.port.options.mk>
> =20
> -.if ${PORT_OPTIONS:MJIT} && ${ARCH} !=3D "sparc64"
> +.if ${PORT_OPTIONS:MJIT} && ${ARCH} !=3D "sparc64" && ${ARCH} !=3D "ia64"
>  CONFIGURE_ARGS+=3D       --enable-jit
>  .else
>  CONFIGURE_ARGS+=3D       --disable-jit
>=20


OPTIONS_EXCLUDE_ia64=3D JIT
OTPIONS_EXCLUDE_sparc64=3D JIT

Would be cleaner imho

> This patch is helpful because
> pcre failure on ia64 portscluster blocks an
> estimated 5658 other ports, so would
> be good to get it committed.
>=20
> HOwever, I wonder if it's better to=20
> check for $ARCH=3D"i386" && $ARCH=3D"amd64",
> now that we have ppc and arm in portscluster.
> I guess there's no JIT support for those
> arches either.

In that case:
OPTIONS_DEFINE_i386=3D JIT
OPTIONS_DEFINE_amd64=3D JIT

regards,
Bapt

--Lb0e7rgc7IsuDeGj
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlBXQOAACgkQ8kTtMUmk6Ewu/wCfc84pfDLFW5rYyvZ+V7xlebKG
A3IAn191hXxevUccob+Ed2qeW5dBLGFR
=G0TN
-----END PGP SIGNATURE-----

--Lb0e7rgc7IsuDeGj--