Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Apr 2015 21:04:24 +0200
From:      Tijl Coosemans <tijl@FreeBSD.org>
To:        Adrian Chadd <adrian@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r281550 - in head: . bin/csh contrib/smbfs/include/netsmb contrib/smbfs/lib/smb include lib/libarchive lib/libc/iconv lib/libc/locale lib/libiconv_modules/BIG5 lib/libiconv_modules/DECH...
Message-ID:  <20150415210424.2fc38e39@kalimero.tijl.coosemans.org>
In-Reply-To: <CAJ-Vmo=RLVjTXXnzP5GT_3db58jc%2B1%2B4Ceq6K=vrT4HKT9wiqA@mail.gmail.com>
References:  <201504150909.t3F99LFB048690@svn.freebsd.org> <CAJ-Vmo=RLVjTXXnzP5GT_3db58jc%2B1%2B4Ceq6K=vrT4HKT9wiqA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
--MP_/Jl84pmqTHGsHqD0th0oIFx=
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Wed, 15 Apr 2015 11:29:19 -0700 Adrian Chadd <adrian@freebsd.org> wrote:
> cc1: warnings being treated as errors
> /usr/home/adrian/work/freebsd/embedded/head/src/bin/csh/../../contrib/tcsh/sh.func.c:
> In function 'iconv_catgets':
> /usr/home/adrian/work/freebsd/embedded/head/src/bin/csh/../../contrib/tcsh/sh.func.c:2599:
> warning: passing argument 2 of 'dl_iconv' from incompatible pointer
> type

Does "embedded" mean that WITHOUT_ICONV is defined?
Can you try the attached patch?
--MP_/Jl84pmqTHGsHqD0th0oIFx=
Content-Type: text/x-patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=iconv.patch

Index: bin/csh/iconv_stub.h
===================================================================
--- bin/csh/iconv_stub.h	(revision 281561)
+++ bin/csh/iconv_stub.h	(working copy)
@@ -30,7 +30,7 @@
 #define _ICONV_H_
 
 typedef void *iconv_t;
-typedef size_t dl_iconv_t(iconv_t, const char **, size_t *, char **, size_t *);
+typedef size_t dl_iconv_t(iconv_t, char **, size_t *, char **, size_t *);
 typedef int dl_iconv_close_t(iconv_t);
 
 extern iconv_t dl_iconv_open(const char *, const char *);

--MP_/Jl84pmqTHGsHqD0th0oIFx=--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150415210424.2fc38e39>