Date: Mon, 14 Dec 2009 17:12:07 +0100 (CET) From: Pietro Cerutti <gahr@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: marcus@FreeBSD.org Subject: ports/141460: [patch] ports-mgmt/portlint regexp problem Message-ID: <200912141612.nBEGC7LH054336@tucana.bfh.ch> Resent-Message-ID: <200912141610.nBEGA3CY041477@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 141460
>Category: ports
>Synopsis: [patch] ports-mgmt/portlint regexp problem
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Dec 14 16:10:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Pietro Cerutti
>Release: FreeBSD 9.0-CURRENT sparc64
>Organization:
The FreeBSD Project
>Environment:
System: FreeBSD tucana.bfh.ch 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Thu Dec 3 19:51:47 CET 2009 root@tucana.bfh.ch:/usr/obj/usr/src/sys/TUCANA sparc64
>Description:
Portlint incorrectly uses the regexp "/a.out$" to match files named 'a.out'. Unfortunately, a missing escape before the dot in the regexp turns the meaning in 'a', followed by any digits, followerd by 'out'.
>How-To-Repeat:
Run portlint in java/netbeans, for example. A warning is produced about a file named 'about'.
>Fix:
Index: src/portlint.pl
===================================================================
RCS file: /home/pcvs/ports/ports-mgmt/portlint/src/portlint.pl,v
retrieving revision 1.111
diff -u -r1.111 portlint.pl
--- src/portlint.pl 18 Jul 2009 21:39:07 -0000 1.111
+++ src/portlint.pl 14 Dec 2009 09:58:43 -0000
@@ -839,7 +839,7 @@
"If possible, install this file with a different name.");
}
- if ($_ =~ m|/a.out$| && $_ !~ /^\@/) {
+ if ($_ =~ m|/a\.out$| && $_ !~ /^\@/) {
&perror("WARN", $file, $., "this port installs a file named ".
"\"a.out\". This file may be deleted if ".
"daily_clean_disks_enable=\"YES\" in /etc/periodic.conf. ".
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200912141612.nBEGC7LH054336>