From owner-p4-projects@FreeBSD.ORG Thu Nov 29 05:41:08 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id A888B16A421; Thu, 29 Nov 2007 05:41:08 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 00B0616A418 for ; Thu, 29 Nov 2007 05:41:07 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.181]) by mx1.freebsd.org (Postfix) with ESMTP id E26F413C461 for ; Thu, 29 Nov 2007 05:41:06 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: by wa-out-1112.google.com with SMTP id k17so2251157waf for ; Wed, 28 Nov 2007 21:41:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=0zN2YlJdHDjpuxAEoQ+iQYGEA9SdHrokvm8kl88IrP4=; b=FSMTcziXkAVDJa5brjC28pvytoCs7bt5fIXyFodY2/TgCMDpVmjEsdpL+Q6vOWcY9sE8OTCovb/Hr6jOPz0oyW3lu9WB2xirpOy0pTSfZ3A1anNN5drhjz1nJuofyd7rlEMq9QSRNHoBszuVZp5NoL9VvwfTc+rrISLRERygeuk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=tQVL5Yx36zTvj/pz5gPPVPCXn1k+RtL+S8X+hOXN4qnHcBoAmga/5icY3sWj2x3E8Rvu0886kPZNwOESTMoS8nzhENYfLWpwzV7XnJQzr6XAF0WqCLK/4JSQMigmEjJ2Jmoyo7BQOb+0Wi3h1+wDneh8NqsYyzVbrwGoLN1KhrA= Received: by 10.114.15.1 with SMTP id 1mr356214wao.1196313306509; Wed, 28 Nov 2007 21:15:06 -0800 (PST) Received: by 10.114.13.15 with HTTP; Wed, 28 Nov 2007 21:15:06 -0800 (PST) Message-ID: Date: Wed, 28 Nov 2007 21:15:06 -0800 From: "Kip Macy" To: "Robert Watson" In-Reply-To: <20071126115044.J65286@fledge.watson.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200711260527.lAQ5RNSw090238@repoman.freebsd.org> <20071126115044.J65286@fledge.watson.org> Cc: Perforce Change Reviews , Kip Macy Subject: Re: PERFORCE change 129544 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2007 05:41:09 -0000 On Nov 26, 2007 3:55 AM, Robert Watson wrote: > > On Mon, 26 Nov 2007, Kip Macy wrote: > > > http://perforce.freebsd.org/chv.cgi?CH=129544 > > > > Change 129544 by kmacy@kmacy:storage:toestack on 2007/11/26 05:26:43 > > > > disable merging of data into existing mbufs if > > new SB_TOE flag is set > > One of the reasons we compact socket buffers with TCP and other stream > protocols is that if you're dealing with an application/protocol that spits > out data in small chunks (i.e., a series of printfs) and nagel is disabled, > you end up with a series of packets that make quite inefficient use of mbufs, > as the space wasted per chunk of data is significant. Not only that, we bill > for space in socket buffers based on the space held by the full mbuf, not just > the data in the mbuf when it comes to socket buffer resource limits, so you > can rapidly fill up socket buffer limits without compaction in this type of > scenario. I'm not sure which protocols this would affect, but I'd imagine > that RPC-like protocols supporting asynchronous operation (so that you get a > series of replies and responses in flight at once) might be relevant, such as > IMAP. > > On an unrelated not, if we want a non-coalescing modes for socket bufferss, we > should probably also give it a name like "SB_NOCOALESCE" rather than something > TOE-specific. > I agree that making it toe specific is somewhat misleading. I actually think I'll be able to fix my code so that it can cope with data being added to the end of a cluster or mbuf that has already been transmitted. If so, I won't need to pull this along when I bring TOE support into CVS. Thanks for the feedback. -Kip