From owner-cvs-all@FreeBSD.ORG Wed Jun 27 13:48:07 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F215616A468; Wed, 27 Jun 2007 13:48:07 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [210.51.165.229]) by mx1.freebsd.org (Postfix) with ESMTP id 3E9BF13C4B8; Wed, 27 Jun 2007 13:48:06 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from localhost (tarsier.geekcn.org [210.51.165.229]) by tarsier.geekcn.org (Postfix) with ESMTP id 529BCEB3033; Wed, 27 Jun 2007 21:48:05 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([210.51.165.229]) by localhost (mail.geekcn.org [210.51.165.229]) (amavisd-new, port 10024) with ESMTP id qbqBXzJsoOXb; Wed, 27 Jun 2007 21:47:58 +0800 (CST) Received: from charlie.delphij.net (unknown [61.49.187.76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTP id D65D7EB2DD9; Wed, 27 Jun 2007 21:47:57 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:user-agent:mime-version:to:subject: references:in-reply-to:x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=oOSrhzmV4NOs+qDpBQWl6CcWsDF/qsJNdJHe43m1KKm1XiAfb6QHFbcw3iEqkpgTr AvXxXqkoTOkOMTq6SsZgw== Message-ID: <46826A8C.8070908@delphij.net> Date: Wed, 27 Jun 2007 21:47:56 +0800 From: Xin LI User-Agent: Thunderbird 2.0.0.4 (X11/20070615) MIME-Version: 1.0 To: Andrey Chernov , Harti Brandt , Kostik Belousov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200706261910.l5QJALb8093717@repoman.freebsd.org> <20070627093610.GU2268@deviant.kiev.zoral.com.ua> <20070627113859.N64822@knop-beagle.kn.op.dlr.de> <20070627101148.GB44554@nagual.pp.ru> In-Reply-To: <20070627101148.GB44554@nagual.pp.ru> X-Enigmail-Version: 0.95.1 OpenPGP: url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Subject: Re: cvs commit: src/share/mk sys.mk X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2007 13:48:08 -0000 Andrey Chernov wrote: > On Wed, Jun 27, 2007 at 11:39:34AM +0200, Harti Brandt wrote: >> On Wed, 27 Jun 2007, Kostik Belousov wrote: >> >> KB>On Tue, Jun 26, 2007 at 07:10:21PM +0000, Andrey A. Chernov wrote: >> KB>> ache 2007-06-26 19:10:21 UTC >> KB>> >> KB>> FreeBSD src repository >> KB>> >> KB>> Modified files: >> KB>> share/mk sys.mk >> KB>> Log: >> KB>> This is temp workaround of nasty gcc 4.2.0 -O2 bug which may skip the rest >> KB>> of the loop when arrays used inside. >> KB>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32500 >> KB>> >> KB>> Approved by: re (kensmith) >> KB> >> KB>This seems to break cross-build of HEAD on RELENG_6. >> >> And even building on a pre-gcc-4.2.0 CURRENT. > > I just sent this cross-building compatible variant to re@ for approve: > > --- sys.mk.orig 2007-06-27 14:04:15.000000000 +0400 > +++ sys.mk 2007-06-27 14:04:33.000000000 +0400 > @@ -35,7 +35,7 @@ > CFLAGS ?= -O > .else > CC ?= cc > -CFLAGS ?= -O2 -fno-strict-aliasing -fno-tree-vrp -pipe > +CFLAGS ?= -O1 -fno-strict-aliasing -pipe > .endif Nitpicking: I think -O1 implies no strict-aliasing. So -O1 -pipe might be just Ok. Well, I'd say that all these changes looks scary to me. Is there any code in our base system to trigger tree-vrp bug? Do we still have some time to have gcc fixed and tested rather than using band-aid like this? IMHO fixing gcc sounds better than "fix"ing sys.mk if time permits us to fix and test a vendor solution. Cheers,