From owner-svn-src-head@freebsd.org Tue Sep 3 14:07:38 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 56CE0DD8D1; Tue, 3 Sep 2019 14:07:20 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N80R3bwxz4QVM; Tue, 3 Sep 2019 14:07:19 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 326BB1B48C; Tue, 3 Sep 2019 14:06:36 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id E122B93B6; Mon, 22 Apr 2019 07:52:22 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4482276909; Mon, 22 Apr 2019 07:52:22 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 14179935F; Mon, 22 Apr 2019 07:52:22 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 0E528935C; Mon, 22 Apr 2019 07:52:19 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A6331768F8; Mon, 22 Apr 2019 07:52:18 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x42d.google.com with SMTP id t21so5346985pfh.2; Mon, 22 Apr 2019 00:52:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=rnNJl65x1ba9iu7kjsqI60gaQg5pB2i8EccHZL+YQWM=; b=jXszu2gignB0IdFxmx+ZuXWST6U7rmOoRJasUT2rHVOhcdBRGGN+ryneVSPNKbW/pE WwPEnt1OexgWCJox/3pAYWpwmcpA+dPgT70+xngKrpGV7LNsQlvifa5LsPMnuEcPj+3e bEeFi9aR4AdIynl5VUp8VptCHo8IpWejN1kw5bqEM26E/ONSShMY5QISKOxNesRhtrCT fp9rlLg+C7P1+wzTwXQa03tjEaXa8/ZHhdxlkdkj10YEemezbBT7uQ4utbW31MtSPibp CBZ/tnh7EwovLRehbV805qytf9fP8LcSrl5LdENivE6riDeyV/AVC1mfyZ991hQuuABf fxLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=rnNJl65x1ba9iu7kjsqI60gaQg5pB2i8EccHZL+YQWM=; b=J1VtKphQHvcK8ha5fVOssDhdaFPytsZBG2L8Ltjn2t6gp4LYRhew13VkFAUT0+9uia Lo6eWxuGL4+BuF1oX11fdnWsBD+dq4gsVzieNp11sOpHZOAJV0/XvqBGy197RLlE/s/4 b5g/2t1Vyruq2xthKfyxybcQ49FDK5dyt/AwAI9GbGLKizoT256TUcyA+AyKU/wWj03S sxar6SOSJcaV5Mdvxfh4II71uRLNGQeNMSDoNr0Eau+kO1ftIJBM7uWY51yafxXOL92S KZKSDW2iJ2hNlQPyAPd58Kcj/9EcAS/N7ni1YHWTtlHCqscleCP01KDmi+b3PZbwG1K3 ITlA== X-Gm-Message-State: APjAAAVNz8ct312AQTiEm6EehrzyKsMYjES/HdfPwCH5FFmt5rQrg73X n4pqqIUoYaQlpEvqJqH5pucReye0aVI= X-Google-Smtp-Source: APXvYqz9M79adZRpgek668u+XPbzRT96hFGjw8sUredWQ5jAArPMtgeqtYTJ+g6umaSxAwb0lVWepQ== X-Received: by 2002:a63:5a4b:: with SMTP id k11mr17491657pgm.119.1555919536976; Mon, 22 Apr 2019 00:52:16 -0700 (PDT) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id a85sm21342417pfa.166.2019.04.22.00.52.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Apr 2019 00:52:16 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: Re: svn commit: r346530 - in head/sys: netinet netinet6 From: Enji Cooper In-Reply-To: <201904220727.x3M7ROpR009729@repo.freebsd.org> Cc: src-committers , svn-src-all , svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <2F3D6B17-AF4F-4B0F-B20E-5EF41DE851F9@gmail.com> References: <201904220727.x3M7ROpR009729@repo.freebsd.org> To: Hans Petter Selasky X-Mailer: Apple Mail (2.3445.104.8) Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 4482276909 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.966,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:07:38 -0000 X-Original-Date: Mon, 22 Apr 2019 00:52:15 -0700 X-List-Received-Date: Tue, 03 Sep 2019 14:07:38 -0000 > On Apr 22, 2019, at 12:27 AM, Hans Petter Selasky = wrote: >=20 > Author: hselasky > Date: Mon Apr 22 07:27:24 2019 > New Revision: 346530 > URL: https://svnweb.freebsd.org/changeset/base/346530 >=20 > Log: > Fix panic in network stack due to memory use after free in relation = to > fragmented packets. >=20 > When sending IPv4 and IPv6 fragmented packets and a fragment is lost, > the mbuf making up the fragment will remain in the temporary hashed > fragment list for a while. If the network interface departs before = the > so-called slow timeout clears the packet, the fragment causes a panic > when the timeout kicks in due to accessing a freed network interface > structure. >=20 > Make sure that when a network device is departing, all hashed IPv4 = and > IPv6 fragments belonging to it, get freed. >=20 > Backtrace: > panic() > icmp6_reflect() >=20 > hlim =3D ND_IFINFO(m->m_pkthdr.rcvif)->chlim; > ^^^^ rcvif->if_afdata[AF_INET6] is NULL. >=20 > icmp6_error() > frag6_freef() > frag6_slowtimo() > pfslowtimo() > softclock_call_cc() > softclock() > ithread_loop() >=20 > Differential Revision: https://reviews.freebsd.org/D19622 > Reviewed by: bz (network), adrian > MFC after: 1 week > Sponsored by: Mellanox Technologies This commit broke the build on mips, etc: 07:36:06=20 --- ip_reass.o --- 07:36:06=20 /usr/src/sys/netinet/ip_reass.c:641: error: expected ')' before '(' = token 07:36:06 *** [ip_reass.o] Error code 1 EVENTHANDLER_DEFINE looks like it doesn=E2=80=99t work with gcc? Thanks, -Enji=