From nobody Wed Aug 5 15:21:30 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hFYzG5g2xz6nR0G for ; Wed, 05 Aug 2026 15:21:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hFYzG3VZMz47YN for ; Wed, 05 Aug 2026 15:21:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785943290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+WjAIdtg3T33fPP10P0ODaE46nDZJq35ftt+hd9ez1w=; b=rSHRQuMQ+Ka8JYfjkley+n2sXHmcjlfJ+vNVTqcMWFBu1KzdP1jcl49LZuKOHGmmnh5Ngw lerZmlMJM0WwGwjEIZwDMcb2l+Gm9EU+IHPjSrfYmlkLN7AH9IwKKWw3GCyIR9omTx7o2d Q9/bh/IeL3q+l86Fmok0of3Q8G9feMDDKNth0pBLEx2h3vg8y9+m8t8V/ZkKGYWhvhP/IH I4JVmFrGSJsiAeNIMPABKJDwaX+4l6PlvP6mgw7rsr7AtDiug36dhQ7HptmVnxnPqn3Yai fBDPU5UgK3DotoJEDf8G6Tecvn1Cv55pesI/kbiL1CrA0LPVkCLLKGhOnhWOwQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785943290; a=rsa-sha256; cv=none; b=sv70PXilK3lsxwgLtwgwP1wdryoqFTO7i/j7bY8hwi15LT1vEPK6ZtWfV3UGzlH4SxKJy7 CAS5Oc0ie0OUlakHJuXpHBkroF+r0Pf4VpL5sAcmPAAgZo58ukRLO9rXMzQFaqq6gH7v8m 32M3Q7Xahyuq1UIslv3DIuZJhTm9mERoHAvs1aTnk7NXIxPyZiGdpIHs4HNVCyjRtq7p+W vro+JqOqfSpvGsaOVpPYpTPH25yHHhEL0NOgkyT2x2dlmxxP8VhfSlBk/6PLb9BOInENjq vfjMpbSWm74yI5TjTfTTRlF0Xm7Q4iAmU0pfewmQB9OX7HU1mwOBXwgaQzkVXg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785943290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+WjAIdtg3T33fPP10P0ODaE46nDZJq35ftt+hd9ez1w=; b=bUVN997zLoDD7syRUxSVYS6xGrwjiC6ryNqDeX5cSyA2FyjOwD/VBvamDKW4skzc1gD73T vL1S4GYalj0kgiRcGHKTh4DMQ3HjkMgwcviXi+k4v90C4CKi4klGsKG/cuIAXkq/F3W6Fs rjgDuWHXzyWd1ZskcK1ZW06MzBPfH2LjiJwrfHzWkqVoXbeANipHX59rG0/olWpGK6b7zs xqyliloZVdj2GocR2o6xmsubaFWpKbbJ6St+Db1EmR0TvU893MFmi1Be4H+XW9n4tA0sI3 Njsy695cdE35xby5CGW1wYA5UH5R2rTO7NIbyIT5pAd+ueIv0aNZZn0Xmp822g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hFYzG1x5hzg8C for ; Wed, 05 Aug 2026 15:21:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4702b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 05 Aug 2026 15:21:30 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Pouria Mousavizadeh Tehrani Subject: git: 200de1b70e2b - main - rtadvd(8): Fix RA flag inconsistency messages List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pouria X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 200de1b70e2b4f809d1d3a4c430db80b24124468 Auto-Submitted: auto-generated Date: Wed, 05 Aug 2026 15:21:30 +0000 Message-Id: <6a7354fa.4702b.516957b0@gitrepo.freebsd.org> The branch main has been updated by pouria: URL: https://cgit.FreeBSD.org/src/commit/?id=200de1b70e2b4f809d1d3a4c430db80b24124468 commit 200de1b70e2b4f809d1d3a4c430db80b24124468 Author: Pouria Mousavizadeh Tehrani AuthorDate: 2026-08-05 08:27:54 +0000 Commit: Pouria Mousavizadeh Tehrani CommitDate: 2026-08-05 15:20:04 +0000 rtadvd(8): Fix RA flag inconsistency messages During flag inconsistency report, we handle rai->rai_otherflg as a bool, but the value is 0x40. Make it a simple number comparison. PR: 295995 Reviewed by: markj, Faraz Vahedi MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D58672 --- usr.sbin/rtadvd/rtadvd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/usr.sbin/rtadvd/rtadvd.c b/usr.sbin/rtadvd/rtadvd.c index b772f78845d8..1525c992a65b 100644 --- a/usr.sbin/rtadvd/rtadvd.c +++ b/usr.sbin/rtadvd/rtadvd.c @@ -1138,9 +1138,9 @@ ra_input(int len, struct nd_router_advert *nra, syslog(LOG_NOTICE, "M flag inconsistent on %s:" " %s from %s, %s from us", - ifi->ifi_ifname, on_off[!rai->rai_managedflg], + ifi->ifi_ifname, on_off[rai->rai_managedflg == 0], inet_ntop(AF_INET6, &from->sin6_addr, ntopbuf, - sizeof(ntopbuf)), on_off[rai->rai_managedflg]); + sizeof(ntopbuf)), on_off[rai->rai_managedflg != 0]); inconsistent++; } /* O flag */ @@ -1149,9 +1149,9 @@ ra_input(int len, struct nd_router_advert *nra, syslog(LOG_NOTICE, "O flag inconsistent on %s:" " %s from %s, %s from us", - ifi->ifi_ifname, on_off[!rai->rai_otherflg], + ifi->ifi_ifname, on_off[rai->rai_otherflg == 0], inet_ntop(AF_INET6, &from->sin6_addr, ntopbuf, - sizeof(ntopbuf)), on_off[rai->rai_otherflg]); + sizeof(ntopbuf)), on_off[rai->rai_otherflg != 0]); inconsistent++; } /* Reachable Time */