From owner-cvs-src@FreeBSD.ORG Thu Mar 27 00:15:01 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2182E37B422; Thu, 27 Mar 2003 00:15:01 -0800 (PST) Received: from mail.chesapeake.net (chesapeake.net [205.130.220.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id DD6454409A; Thu, 27 Mar 2003 00:02:18 -0800 (PST) (envelope-from jroberson@chesapeake.net) Received: from localhost (jroberson@localhost) by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id h2R82Iw16810; Thu, 27 Mar 2003 03:02:18 -0500 (EST) (envelope-from jroberson@chesapeake.net) Date: Thu, 27 Mar 2003 03:02:18 -0500 (EST) From: Jeff Roberson To: Tor Egge In-Reply-To: <200303262340.h2QNegJg065498@repoman.freebsd.org> Message-ID: <20030327025926.K64602-100000@mail.chesapeake.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Status: No, hits=-16.5 required=5.0 tests=AWL,EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT, REPLY_WITH_QUOTES,SUBJ_HAS_SPACES version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf NOTES files options src/sys/kern vfs_bio.c src/sys/ufs/ffs ffs_rawread.c ffs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Mar 2003 08:15:12 -0000 On Wed, 26 Mar 2003, Tor Egge wrote: > tegge 2003/03/26 15:40:42 PST > > FreeBSD src repository > > Modified files: > sys/conf NOTES files options > sys/kern vfs_bio.c > sys/ufs/ffs ffs_vnops.c > Added files: > sys/ufs/ffs ffs_rawread.c > Log: > Add support for reading directly from file to userland buffer when the > O_DIRECT descriptor status flag is set and both offset and length is a > multiple of the physical media sector size. > Hey, this is great stuff. It wish we could have talked about it a bit before it was commited.. Most of ffs_rawread.c is fairly generic. Do you think you could make a vfs_direct.c or similar and move the generic bits in there? It looks like you could keep the ffs specific bits to a minimum and then leave the rest as helper functions. Do you have an application that is using this immediately? Cheers, Jeff