From owner-freebsd-bugs@FreeBSD.ORG Mon Aug 31 10:40:04 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 777C91065672 for ; Mon, 31 Aug 2009 10:40:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 53F788FC17 for ; Mon, 31 Aug 2009 10:40:04 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n7VAe4BI041027 for ; Mon, 31 Aug 2009 10:40:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n7VAe4hU041026; Mon, 31 Aug 2009 10:40:04 GMT (envelope-from gnats) Resent-Date: Mon, 31 Aug 2009 10:40:04 GMT Resent-Message-Id: <200908311040.n7VAe4hU041026@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Patroklos Argyroudis Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C93EB106566B for ; Mon, 31 Aug 2009 10:31:36 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id B82308FC08 for ; Mon, 31 Aug 2009 10:31:36 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n7VAVaFR076048 for ; Mon, 31 Aug 2009 10:31:36 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n7VAVaHj076047; Mon, 31 Aug 2009 10:31:36 GMT (envelope-from nobody) Message-Id: <200908311031.n7VAVaHj076047@www.freebsd.org> Date: Mon, 31 Aug 2009 10:31:36 GMT From: Patroklos Argyroudis To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/138383: NULL pointer dereference in mach64_dma_vertex() in file sys/dev/drm/mach64_state.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Aug 2009 10:40:04 -0000 >Number: 138383 >Category: kern >Synopsis: NULL pointer dereference in mach64_dma_vertex() in file sys/dev/drm/mach64_state.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Aug 31 10:40:03 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Patroklos Argyroudis >Release: 8.0-CURRENT >Organization: census, inc >Environment: N/A >Description: There is a NULL pointer dereference in mach64_dma_vertex() line 829 in file sys/dev/drm/mach64_state.c. The check against NULL in line 834 should happen before the dereference of dev_priv. >How-To-Repeat: N/A >Fix: Patch attached. Patch attached with submission follows: --- ./sys/dev/drm/mach64_state.c.orig 2009-08-28 15:42:13.000000000 +0300 +++ ./sys/dev/drm/mach64_state.c 2009-08-28 15:55:17.000000000 +0300 @@ -826,7 +826,7 @@ struct drm_file *file_priv) { drm_mach64_private_t *dev_priv = dev->dev_private; - drm_mach64_sarea_t *sarea_priv = dev_priv->sarea_priv; + drm_mach64_sarea_t *sarea_priv; drm_mach64_vertex_t *vertex = data; LOCK_TEST_WITH_RETURN(dev, file_priv); @@ -836,6 +836,8 @@ return -EINVAL; } + sarea_priv = dev_priv->sarea_priv; + DRM_DEBUG("pid=%d buf=%p used=%lu discard=%d\n", DRM_CURRENTPID, vertex->buf, vertex->used, vertex->discard); >Release-Note: >Audit-Trail: >Unformatted: