From owner-freebsd-current@FreeBSD.ORG Fri Jun 6 12:16:03 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 10291106568A for ; Fri, 6 Jun 2008 12:16:03 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from fk-out-0910.google.com (fk-out-0910.google.com [209.85.128.191]) by mx1.freebsd.org (Postfix) with ESMTP id 814808FC6F for ; Fri, 6 Jun 2008 12:16:02 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by fk-out-0910.google.com with SMTP id k31so809503fkk.11 for ; Fri, 06 Jun 2008 05:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent:sender; bh=mw8ItymZLyo/VK5GrvLEsVAizoyKVOmhJXFiD0TN/54=; b=mrcsyysP5udLGnAWZsL31l/A/XBCTaZEnGpFKDAJq/iUxwTRuj3yj9Syub3+2PgIHH VwpVwqbZHUbsFjWsEQuFfSmeW22sBC+goI7mLpUEFaoei0xeonN2Nln/AHXxNJaRNNfo UultfnAy8zCRCaf6nqoE10GAuaRUO5Cr4slB4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent:sender; b=mmQVMGIYJGGUiQ+H8tToAii6j1JamWJQ/sCRRK1ZUJgNLAh7PoX8sm8VmbxqRslSrh R+ZsvTWP2FeGAoBiFhukln9zreDiNfSkU4z9vKL3OpU3H3qU1Mop3Sk27KL31W0Wz5n5 d76LezxQehaSZa442fbWOpsGOdJob2IF1rdVo= Received: by 10.78.199.8 with SMTP id w8mr26232huf.106.1212754561144; Fri, 06 Jun 2008 05:16:01 -0700 (PDT) Received: from epsilon.local ( [89.214.195.159]) by mx.google.com with ESMTPS id 38sm5043317hua.42.2008.06.06.05.15.58 (version=SSLv3 cipher=RC4-MD5); Fri, 06 Jun 2008 05:16:00 -0700 (PDT) Date: Fri, 6 Jun 2008 13:15:52 +0100 From: Rui Paulo To: Stanislav Sedov Message-ID: <20080606121552.GA7768@epsilon.local> References: <20080605231705.db589d89.stas@FreeBSD.org> <20080605204823.GA7361@epsilon.local> <20080606020927.8d6675e1.stas@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080606020927.8d6675e1.stas@FreeBSD.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: Rui Paulo Cc: kib@FreeBSD.org, Rui Paulo , current@FreeBSD.org Subject: Re: cpuctl(formely devcpu) patch test request X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jun 2008 12:16:03 -0000 On Fri, Jun 06, 2008 at 02:09:27AM +0400, Stanislav Sedov wrote: > On Thu, 5 Jun 2008 21:55:39 +0100 > Rui Paulo mentioned: > > > A couple comments: > > 1) Do you plan to MFC this ? For what older versions of FreeBSD will devcpu be > > shipped? > > In fact, I plan to MFC that to all supported FreeBSD versions (6, 7), > as changes are minimal. Until that those versions will be supported > by sysutils/devcpu port. Ok. > > > > 2) in cpuctl_modevent(): perhaps it's better to return ENOMEM instead of > > ENOSYS if malloc() fails and ENXIO instead of ENOSYS if MSR functionality is > > not present > > I fully agree on ENOMEM (thanks for noticing that), while I think that > returning ENOSYS for MSR-less systems is more correct, as it states that > required functionality isn't implemented for this hardware. Agreed. > > 3) I don't mean to impose, but this code needs some small style cleanup, > > namely: characters above the 80 column, second level indents are four > > spaces" > > Good catch! Fixed. Good, thanks. -- Rui Paulo